From: Ian Campbell <ian.campbell@citrix.com>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: "Prasun.kapoor@cavium.com" <Prasun.kapoor@cavium.com>,
"Jaggi, Manish" <Manish.Jaggi@caviumnetworks.com>,
Julien Grall <julien.grall@linaro.org>,
"Kumar, Vijaya" <Vijaya.Kumar@caviumnetworks.com>,
Xen Devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH v1 3/3] xen/arm: smmu: Renaming struct iommu_domain *domain to, struct iommu_domain *iommu_domain
Date: Wed, 1 Apr 2015 09:30:31 +0100 [thread overview]
Message-ID: <1427877031.2115.212.camel@citrix.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1503311738450.7690@kaball.uk.xensource.com>
On Tue, 2015-03-31 at 17:48 +0100, Stefano Stabellini wrote:
> If it helps we could add a couple of comments on top of the structs in
> smmu.c to explain the meaning of the fields, like:
>
>
> /* iommu_domain, not to be confused with a Xen domain */
I was going to suggest something similar but more expansive, i.e. a
table of them all in one place (i.e. at the top of the file) for ease of
referencing:
Struct Name What Wherefrom Normally found in
---------------------------------------------------------------------
iommu_domain IOMMU Context Linux d->arch.blah
arch_smmu_xen_device Device specific Xen device->arch.blurg
Ian.
next prev parent reply other threads:[~2015-04-01 8:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-27 7:24 [PATCH v1 3/3] xen/arm: smmu: Renaming struct iommu_domain *domain to, struct iommu_domain *iommu_domain Manish Jaggi
2015-03-27 13:04 ` Julien Grall
2015-03-27 13:26 ` Jaggi, Manish
2015-03-27 13:41 ` Julien Grall
2015-03-27 18:05 ` Jaggi, Manish
2015-03-27 19:20 ` Julien Grall
2015-03-31 16:48 ` Stefano Stabellini
2015-04-01 8:30 ` Ian Campbell [this message]
2015-04-06 14:15 ` Julien Grall
2015-04-14 11:15 ` Ian Campbell
2015-04-14 11:46 ` Julien Grall
2015-04-14 12:24 ` Jaggi, Manish
2015-04-14 12:47 ` Julien Grall
2015-04-14 14:19 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1427877031.2115.212.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=Manish.Jaggi@caviumnetworks.com \
--cc=Prasun.kapoor@cavium.com \
--cc=Vijaya.Kumar@caviumnetworks.com \
--cc=julien.grall@linaro.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.