From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH 21/29] libxl: cancellation: Make spawns cancellable Date: Wed, 1 Apr 2015 10:40:09 +0100 Message-ID: <1427881209.2115.256.camel@citrix.com> References: <1423599016-32639-1-git-send-email-ian.jackson@eu.citrix.com> <1423599016-32639-22-git-send-email-ian.jackson@eu.citrix.com> <1427198022.21742.364.camel@citrix.com> <21786.60220.577051.878861@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <21786.60220.577051.878861@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson Cc: xen-devel@lists.xensource.com, Euan Harris List-Id: xen-devel@lists.xenproject.org On Tue, 2015-03-31 at 19:45 +0100, Ian Jackson wrote: > Ian Campbell writes ("Re: [Xen-devel] [PATCH 21/29] libxl: cancellation: Make spawns cancellable"): > > On Tue, 2015-02-10 at 20:10 +0000, Ian Jackson wrote: > > > The libxl__spawn_spawn internal API permits the caller to specify > > > .timeout_ms==-1, meaning to wait forever. Provide an explicit > > > cancellable to allow spawns to be cancelled. > > > > AIUI this also lets spawns with timeout_ms > -1 to be cancelled, which I > > think is desirable. > > Yes. > > Spawns with finite timeouts will be cancelled either by the explicit > cancellable in the spawn, or the one implied by the finite timeout; it > doesn't matter which - the path goes from spawn_cancel or > spawn_watch_event (respectively) to spawn_fail. > > I was going to say that this patch is needed because libxl__ev_time's > cancellable is not registered when the timeout is infinite. But > actually I see from libxl_event.c that this isn't the case. So I > think I should drop this patch. OK.