From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753243AbbDANQB (ORCPT ); Wed, 1 Apr 2015 09:16:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58373 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751797AbbDANP5 (ORCPT ); Wed, 1 Apr 2015 09:15:57 -0400 From: Gerd Hoffmann To: dri-devel@lists.freedesktop.org, virtio-dev@lists.oasis-open.org Cc: airlied@gmail.com, airlied@redhat.com, mst@redhat.com, Gerd Hoffmann , Mauro Carvalho Chehab , linux-media@vger.kernel.org (open list:MEDIA INPUT INFRA...), linux-kernel@vger.kernel.org (open list) Subject: [PATCH v2 1/4] break kconfig dependency loop Date: Wed, 1 Apr 2015 15:15:27 +0200 Message-Id: <1427894130-14228-2-git-send-email-kraxel@redhat.com> In-Reply-To: <1427894130-14228-1-git-send-email-kraxel@redhat.com> References: <1427894130-14228-1-git-send-email-kraxel@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org After adding virtio-gpu I get this funky kconfig dependency loop. scripts/kconfig/conf --oldconfig Kconfig drivers/video/fbdev/Kconfig:5:error: recursive dependency detected! drivers/video/fbdev/Kconfig:5: symbol FB is selected by DRM_KMS_FB_HELPER drivers/gpu/drm/Kconfig:34: symbol DRM_KMS_FB_HELPER is selected by DRM_VIRTIO_GPU drivers/gpu/drm/virtio/Kconfig:1: symbol DRM_VIRTIO_GPU depends on VIRTIO drivers/virtio/Kconfig:1: symbol VIRTIO is selected by REMOTEPROC drivers/remoteproc/Kconfig:4: symbol REMOTEPROC is selected by OMAP_REMOTEPROC drivers/remoteproc/Kconfig:12: symbol OMAP_REMOTEPROC depends on OMAP_IOMMU drivers/iommu/Kconfig:141: symbol OMAP_IOMMU is selected by VIDEO_OMAP3 drivers/media/platform/Kconfig:96: symbol VIDEO_OMAP3 depends on VIDEO_V4L2 drivers/media/v4l2-core/Kconfig:6: symbol VIDEO_V4L2 depends on I2C drivers/i2c/Kconfig:7: symbol I2C is selected by FB_DDC drivers/video/fbdev/Kconfig:59: symbol FB_DDC is selected by FB_CYBER2000_DDC drivers/video/fbdev/Kconfig:374: symbol FB_CYBER2000_DDC depends on FB_CYBER2000 drivers/video/fbdev/Kconfig:362: symbol FB_CYBER2000 depends on FB Making VIDEO_OMAP3 depend on OMAP_IOMMU instead of selecting it breaks the loop, which looks like the best way to handle it to me. I'm open to better suggestions though. Signed-off-by: Gerd Hoffmann --- drivers/media/platform/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig index d9b872b..fc21734 100644 --- a/drivers/media/platform/Kconfig +++ b/drivers/media/platform/Kconfig @@ -87,8 +87,8 @@ config VIDEO_OMAP3 tristate "OMAP 3 Camera support" depends on VIDEO_V4L2 && I2C && VIDEO_V4L2_SUBDEV_API && ARCH_OMAP3 depends on HAS_DMA + depends on OMAP_IOMMU select ARM_DMA_USE_IOMMU - select OMAP_IOMMU select VIDEOBUF2_DMA_CONTIG ---help--- Driver for an OMAP 3 camera controller. -- 1.8.3.1 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gerd Hoffmann Subject: [PATCH v2 1/4] break kconfig dependency loop Date: Wed, 1 Apr 2015 15:15:27 +0200 Message-ID: <1427894130-14228-2-git-send-email-kraxel@redhat.com> References: <1427894130-14228-1-git-send-email-kraxel@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by gabe.freedesktop.org (Postfix) with ESMTP id 228076E872 for ; Wed, 1 Apr 2015 06:15:57 -0700 (PDT) In-Reply-To: <1427894130-14228-1-git-send-email-kraxel@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org, virtio-dev@lists.oasis-open.org Cc: Mauro Carvalho Chehab , mst@redhat.com, open list , airlied@redhat.com, "open list:MEDIA INPUT INFRA..." List-Id: dri-devel@lists.freedesktop.org QWZ0ZXIgYWRkaW5nIHZpcnRpby1ncHUgSSBnZXQgdGhpcyBmdW5reSBrY29uZmlnIGRlcGVuZGVu Y3kgbG9vcC4KCnNjcmlwdHMva2NvbmZpZy9jb25mIC0tb2xkY29uZmlnIEtjb25maWcKZHJpdmVy cy92aWRlby9mYmRldi9LY29uZmlnOjU6ZXJyb3I6IHJlY3Vyc2l2ZSBkZXBlbmRlbmN5IGRldGVj dGVkIQpkcml2ZXJzL3ZpZGVvL2ZiZGV2L0tjb25maWc6NTogIHN5bWJvbCBGQiBpcyBzZWxlY3Rl ZCBieSBEUk1fS01TX0ZCX0hFTFBFUgpkcml2ZXJzL2dwdS9kcm0vS2NvbmZpZzozNDogICAgIHN5 bWJvbCBEUk1fS01TX0ZCX0hFTFBFUiBpcyBzZWxlY3RlZCBieSBEUk1fVklSVElPX0dQVQpkcml2 ZXJzL2dwdS9kcm0vdmlydGlvL0tjb25maWc6MTogICAgICAgc3ltYm9sIERSTV9WSVJUSU9fR1BV IGRlcGVuZHMgb24gVklSVElPCmRyaXZlcnMvdmlydGlvL0tjb25maWc6MTogICAgICAgc3ltYm9s IFZJUlRJTyBpcyBzZWxlY3RlZCBieSBSRU1PVEVQUk9DCmRyaXZlcnMvcmVtb3RlcHJvYy9LY29u ZmlnOjQ6ICAgc3ltYm9sIFJFTU9URVBST0MgaXMgc2VsZWN0ZWQgYnkgT01BUF9SRU1PVEVQUk9D CmRyaXZlcnMvcmVtb3RlcHJvYy9LY29uZmlnOjEyOiAgc3ltYm9sIE9NQVBfUkVNT1RFUFJPQyBk ZXBlbmRzIG9uIE9NQVBfSU9NTVUKZHJpdmVycy9pb21tdS9LY29uZmlnOjE0MTogICAgICBzeW1i b2wgT01BUF9JT01NVSBpcyBzZWxlY3RlZCBieSBWSURFT19PTUFQMwpkcml2ZXJzL21lZGlhL3Bs YXRmb3JtL0tjb25maWc6OTY6ICAgICAgc3ltYm9sIFZJREVPX09NQVAzIGRlcGVuZHMgb24gVklE RU9fVjRMMgpkcml2ZXJzL21lZGlhL3Y0bDItY29yZS9LY29uZmlnOjY6ICAgICAgc3ltYm9sIFZJ REVPX1Y0TDIgZGVwZW5kcyBvbiBJMkMKZHJpdmVycy9pMmMvS2NvbmZpZzo3OiAgc3ltYm9sIEky QyBpcyBzZWxlY3RlZCBieSBGQl9EREMKZHJpdmVycy92aWRlby9mYmRldi9LY29uZmlnOjU5OiBz eW1ib2wgRkJfRERDIGlzIHNlbGVjdGVkIGJ5IEZCX0NZQkVSMjAwMF9EREMKZHJpdmVycy92aWRl by9mYmRldi9LY29uZmlnOjM3NDogICAgICAgIHN5bWJvbCBGQl9DWUJFUjIwMDBfRERDIGRlcGVu ZHMgb24gRkJfQ1lCRVIyMDAwCmRyaXZlcnMvdmlkZW8vZmJkZXYvS2NvbmZpZzozNjI6ICAgICAg ICBzeW1ib2wgRkJfQ1lCRVIyMDAwIGRlcGVuZHMgb24gRkIKCk1ha2luZyBWSURFT19PTUFQMyBk ZXBlbmQgb24gT01BUF9JT01NVSBpbnN0ZWFkIG9mIHNlbGVjdGluZyBpdCBicmVha3MgdGhlCmxv b3AsIHdoaWNoIGxvb2tzIGxpa2UgdGhlIGJlc3Qgd2F5IHRvIGhhbmRsZSBpdCB0byBtZS4gIEkn bSBvcGVuIHRvIGJldHRlcgpzdWdnZXN0aW9ucyB0aG91Z2guCgpTaWduZWQtb2ZmLWJ5OiBHZXJk IEhvZmZtYW5uIDxrcmF4ZWxAcmVkaGF0LmNvbT4KLS0tCiBkcml2ZXJzL21lZGlhL3BsYXRmb3Jt L0tjb25maWcgfCAyICstCiAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDEgZGVsZXRp b24oLSkKCmRpZmYgLS1naXQgYS9kcml2ZXJzL21lZGlhL3BsYXRmb3JtL0tjb25maWcgYi9kcml2 ZXJzL21lZGlhL3BsYXRmb3JtL0tjb25maWcKaW5kZXggZDliODcyYi4uZmMyMTczNCAxMDA2NDQK LS0tIGEvZHJpdmVycy9tZWRpYS9wbGF0Zm9ybS9LY29uZmlnCisrKyBiL2RyaXZlcnMvbWVkaWEv cGxhdGZvcm0vS2NvbmZpZwpAQCAtODcsOCArODcsOCBAQCBjb25maWcgVklERU9fT01BUDMKIAl0 cmlzdGF0ZSAiT01BUCAzIENhbWVyYSBzdXBwb3J0IgogCWRlcGVuZHMgb24gVklERU9fVjRMMiAm JiBJMkMgJiYgVklERU9fVjRMMl9TVUJERVZfQVBJICYmIEFSQ0hfT01BUDMKIAlkZXBlbmRzIG9u IEhBU19ETUEKKwlkZXBlbmRzIG9uIE9NQVBfSU9NTVUKIAlzZWxlY3QgQVJNX0RNQV9VU0VfSU9N TVUKLQlzZWxlY3QgT01BUF9JT01NVQogCXNlbGVjdCBWSURFT0JVRjJfRE1BX0NPTlRJRwogCS0t LWhlbHAtLS0KIAkgIERyaXZlciBmb3IgYW4gT01BUCAzIGNhbWVyYSBjb250cm9sbGVyLgotLSAK MS44LjMuMQoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K ZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0 dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK