From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753302AbbDANnN (ORCPT ); Wed, 1 Apr 2015 09:43:13 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40669 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752117AbbDANnM (ORCPT ); Wed, 1 Apr 2015 09:43:12 -0400 Message-ID: <1427895778.6445.13.camel@nilsson.home.kraxel.org> Subject: Re: [PATCH v2 4/4] Add virtio-vga bits. From: Gerd Hoffmann To: "Michael S. Tsirkin" Cc: dri-devel@lists.freedesktop.org, virtio-dev@lists.oasis-open.org, airlied@gmail.com, airlied@redhat.com, David Airlie , Rusty Russell , open list , "open list:VIRTIO CORE, NET..." Date: Wed, 01 Apr 2015 15:42:58 +0200 In-Reply-To: <20150401152535-mutt-send-email-mst@redhat.com> References: <1427894130-14228-1-git-send-email-kraxel@redhat.com> <1427894130-14228-5-git-send-email-kraxel@redhat.com> <20150401152535-mutt-send-email-mst@redhat.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mi, 2015-04-01 at 15:26 +0200, Michael S. Tsirkin wrote: > On Wed, Apr 01, 2015 at 03:15:30PM +0200, Gerd Hoffmann wrote: > > +static void virtio_pci_kick_out_firmware_fb(struct pci_dev *pci_dev) > > +{ > > + struct apertures_struct *ap; > > + bool primary; > > + > > + ap = alloc_apertures(1); > > + if (!ap) > > + return; > > + > > + ap->ranges[0].base = pci_resource_start(pci_dev, 2); > > + ap->ranges[0].size = pci_resource_len(pci_dev, 2); > > I thought you mentioned it's better to switch to a different BAR > to be compatible with stdvga? Indeed, thats why the cover letter lists this as todo item, because it isn't sorted yet. Need to figure a sane way to handle this on the host side. Current plan is trying to make virtio_pci_device_plugged() configurable without making things too messy. cheers, Gerd From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gerd Hoffmann Subject: Re: [PATCH v2 4/4] Add virtio-vga bits. Date: Wed, 01 Apr 2015 15:42:58 +0200 Message-ID: <1427895778.6445.13.camel@nilsson.home.kraxel.org> References: <1427894130-14228-1-git-send-email-kraxel@redhat.com> <1427894130-14228-5-git-send-email-kraxel@redhat.com> <20150401152535-mutt-send-email-mst@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20150401152535-mutt-send-email-mst@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: "Michael S. Tsirkin" Cc: virtio-dev@lists.oasis-open.org, David Airlie , open list , dri-devel@lists.freedesktop.org, "open list:VIRTIO CORE, NET..." , airlied@redhat.com, airlied@gmail.com List-Id: virtualization@lists.linuxfoundation.org On Mi, 2015-04-01 at 15:26 +0200, Michael S. Tsirkin wrote: > On Wed, Apr 01, 2015 at 03:15:30PM +0200, Gerd Hoffmann wrote: > > +static void virtio_pci_kick_out_firmware_fb(struct pci_dev *pci_dev) > > +{ > > + struct apertures_struct *ap; > > + bool primary; > > + > > + ap = alloc_apertures(1); > > + if (!ap) > > + return; > > + > > + ap->ranges[0].base = pci_resource_start(pci_dev, 2); > > + ap->ranges[0].size = pci_resource_len(pci_dev, 2); > > I thought you mentioned it's better to switch to a different BAR > to be compatible with stdvga? Indeed, thats why the cover letter lists this as todo item, because it isn't sorted yet. Need to figure a sane way to handle this on the host side. Current plan is trying to make virtio_pci_device_plugged() configurable without making things too messy. cheers, Gerd