From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH OSSTEST v4 01/25] TestSupport: Add helper to
 fetch a URL on a host
Date: Thu, 2 Apr 2015 13:26:41 +0100
Message-ID: <1427977601.4037.64.camel@citrix.com>
References: <1427966183.4037.17.camel@citrix.com>
	<1427966199-5064-1-git-send-email-ian.campbell@citrix.com>
	<21789.9945.123578.328119@mariner.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <21789.9945.123578.328119@mariner.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On Thu, 2015-04-02 at 12:24 +0100, Ian Jackson wrote:
> Ian Campbell writes ("[PATCH OSSTEST v4 01/25] TestSupport: Add helper to fetch a URL on a host"):
> > Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
> 
> We're not using this to fetch URLs on the public internet, are we ?
> If we are then we need to honour $c{HttpProxy}.

It is used to fetch the kernel+initrd to test, which previously came
from the apt cache, via $c{DebianMirrorHost}.

Would you recommend $c{HttpProxy} or ${DebianMirrorProxy} for this? I
think given the generic nature only the former, even though the only
caller is currently grabbing apt-cachable things.

> Perhaps you could add a comment to the effect that target_fetch_url
> should be used for URLs within the test environment, only.
> 
> Ian.