All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Campbell <ian.campbell@citrix.com>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: longtaox.pang@intel.com, xen-devel@lists.xen.org
Subject: Re: [PATCH OSSTEST v4 05/25] Debian: refactor preseeding of .ssh directories
Date: Thu, 2 Apr 2015 13:39:17 +0100	[thread overview]
Message-ID: <1427978357.4037.69.camel@citrix.com> (raw)
In-Reply-To: <21789.10496.425187.458425@mariner.uk.xensource.com>

On Thu, 2015-04-02 at 12:33 +0100, Ian Jackson wrote:
> Ian Campbell writes ("[PATCH OSSTEST v4 05/25] Debian: refactor preseeding of .ssh directories"):
> > Causes known_hosts to be consistently created as well as ~osstest/.ssh
> > to be consistently populated (it previsouly wasn't for HVM guests).
> 
> Most of this is code motion, AFAICT.  The difference is just that
> preseed_ssh is now called from ts-debian-hvm-install, too ?
> 
> Why should preseed_ssh not be used by preseed_base ?

Good question, I think it could be. At least I can't think of any sort
of preseedable thing we would want to install which doesn't want this.
I'll try it for next time.

preseed_base today is only concerned with creating the base text for the
pressed file, whereas preseed_ssh does more stuff like adding webfiles
and adding preseed hooks.

I take it you don't see that as a problem?

Ian.

  reply	other threads:[~2015-04-02 12:39 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-02  9:16 [PATCH OSSTEST v4 00/25] add distro domU testing flight Ian Campbell
2015-04-02  9:16 ` [PATCH OSSTEST v4 01/25] TestSupport: Add helper to fetch a URL on a host Ian Campbell
2015-04-02 11:24   ` Ian Jackson
2015-04-02 12:26     ` Ian Campbell
2015-04-02  9:16 ` [PATCH OSSTEST v4 02/25] TestSupport: allow caller of prepareguest_part_xencfg to specify viftype Ian Campbell
2015-04-02 11:25   ` Ian Jackson
2015-04-02  9:16 ` [PATCH OSSTEST v4 03/25] create_webfile: Support use with guests as well as hosts Ian Campbell
2015-04-02 11:26   ` Ian Jackson
2015-04-02  9:16 ` [PATCH OSSTEST v4 04/25] Debian: refactor code to add preseed commands to the preseed file Ian Campbell
2015-04-02 11:31   ` Ian Jackson
2015-04-02 12:29     ` Ian Campbell
2015-04-02  9:16 ` [PATCH OSSTEST v4 05/25] Debian: refactor preseeding of .ssh directories Ian Campbell
2015-04-02 11:33   ` Ian Jackson
2015-04-02 12:39     ` Ian Campbell [this message]
2015-04-02  9:16 ` [PATCH OSSTEST v4 06/25] Debian: Refactor installation of overlays, so it can be used for guests too Ian Campbell
2015-04-02 11:35   ` Ian Jackson
2015-04-02  9:16 ` [PATCH OSSTEST v4 07/25] Debian: add preseed_create_guest helper Ian Campbell
2015-04-02 11:40   ` Ian Jackson
2015-04-02 12:44     ` Ian Campbell
2015-04-02  9:16 ` [PATCH OSSTEST v4 08/25] make-flight: Handle $BUILD_LVEXTEND_MAX in mfi-common:create_build_jobs() Ian Campbell
2015-04-14 15:45   ` Ian Jackson
2015-04-02  9:16 ` [PATCH OSSTEST v4 09/25] distros: add support for installing Debian PV guests via d-i, flight and jobs Ian Campbell
2015-04-02  9:16 ` [PATCH OSSTEST v4 10/25] distros: support booting Debian PV (d-i installed) guests with pvgrub Ian Campbell
2015-04-02  9:16 ` [PATCH OSSTEST v4 11/25] distros: Support pvgrub for Wheezy too Ian Campbell
2015-04-02  9:16 ` [PATCH OSSTEST v4 12/25] distros: support PV guest install from Debian netinst media Ian Campbell
2015-04-02  9:16 ` [PATCH OSSTEST v4 13/25] Test pygrub and pvgrub on the regular flights Ian Campbell
2015-04-02  9:16 ` [PATCH OSSTEST v4 14/25] distros: add branch infrastructure Ian Campbell
2015-04-02  9:16 ` [PATCH OSSTEST v4 15/25] distros: Run a flight over the weekend Ian Campbell
2015-04-02  9:16 ` [PATCH OSSTEST v4 16/25] Debian: Handle lack of bootloader support in d-i on ARM Ian Campbell
2015-04-02  9:16 ` [PATCH OSSTEST v4 17/25] standalone: propagate result of command from with_logging Ian Campbell
2015-04-02  9:16 ` [PATCH OSSTEST v4 18/25] ts-debian-di-install: Refactor root_disk specification Ian Campbell
2015-04-02  9:16 ` [PATCH OSSTEST v4 19/25] make-flight: refactor PV debian tests Ian Campbell
2015-04-02  9:16 ` [PATCH OSSTEST v4 20/25] Add testing of non-LVM/phy disk backends Ian Campbell
2015-04-02  9:16 ` [PATCH OSSTEST v4 21/25] mfi-common: Allow make-*flight to filter the set of build jobs to include Ian Campbell
2015-04-02  9:16 ` [PATCH OSSTEST v4 22/25] make-distros-flight: don't bother building for XSM Ian Campbell
2015-04-02  9:16 ` [PATCH OSSTEST v4 23/25] Debian.pm: Assume 100MB/s dd from /dev/zero when creating a raw disk image Ian Campbell
2015-04-02  9:16 ` [PATCH OSSTEST v4 24/25] distros: email only me on play flights Ian Campbell
2015-04-02  9:16 ` [PATCH OSSTEST v4 25/25] ts-debian-di-install: Use ftp.debian.org directly Ian Campbell
2015-04-02 11:21 ` [PATCH OSSTEST v4 00/25] add distro domU testing flight Ian Jackson
2015-04-02 12:24   ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1427978357.4037.69.camel@citrix.com \
    --to=ian.campbell@citrix.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=longtaox.pang@intel.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.