All of lore.kernel.org
 help / color / mirror / Atom feed
From: Robert Baldyga <r.baldyga@samsung.com>
To: cw00.choi@samsung.com
Cc: myungjoo.ham@samsung.com, rogerq@ti.com,
	linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, m.szyprowski@samsung.com,
	Robert Baldyga <r.baldyga@samsung.com>
Subject: [PATCH v3 3/4] extcon: usb-gpio: make debounce value configurable in devicetree
Date: Thu, 02 Apr 2015 15:13:04 +0200	[thread overview]
Message-ID: <1427980385-21285-4-git-send-email-r.baldyga@samsung.com> (raw)
In-Reply-To: <1427980385-21285-1-git-send-email-r.baldyga@samsung.com>

This patch adds devicetree property for setting debounce value. It allows
to set debounce time shorter or longer depending on the needs of given
platform.

Signed-off-by: Robert Baldyga <r.baldyga@samsung.com>
Acked-by: Roger Quadros <rogerq@ti.com>
---
 drivers/extcon/extcon-usb-gpio.c | 14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)

diff --git a/drivers/extcon/extcon-usb-gpio.c b/drivers/extcon/extcon-usb-gpio.c
index baf7add..fe223bf 100644
--- a/drivers/extcon/extcon-usb-gpio.c
+++ b/drivers/extcon/extcon-usb-gpio.c
@@ -116,6 +116,7 @@ static int usb_extcon_probe(struct platform_device *pdev)
 	struct device *dev = &pdev->dev;
 	struct device_node *np = dev->of_node;
 	struct usb_extcon_info *info;
+	u32 debounce;
 	int ret;
 
 	if (!np)
@@ -126,6 +127,11 @@ static int usb_extcon_probe(struct platform_device *pdev)
 		return -ENOMEM;
 
 	info->dev = dev;
+
+	ret = of_property_read_u32(np, "debounce", &debounce);
+	if (ret < 0)
+		debounce = USB_GPIO_DEBOUNCE_MS;
+
 	info->id_gpiod = devm_gpiod_get_optional(&pdev->dev, "id");
 	info->vbus_gpiod = devm_gpiod_get_optional(&pdev->dev, "vbus");
 
@@ -147,16 +153,14 @@ static int usb_extcon_probe(struct platform_device *pdev)
 	}
 
 	if (info->id_gpiod)
-		ret = gpiod_set_debounce(info->id_gpiod,
-			USB_GPIO_DEBOUNCE_MS * 1000);
+		ret = gpiod_set_debounce(info->id_gpiod, debounce * 1000);
 	if (!ret && info->vbus_gpiod) {
-		ret = gpiod_set_debounce(info->vbus_gpiod,
-			USB_GPIO_DEBOUNCE_MS * 1000);
+		ret = gpiod_set_debounce(info->vbus_gpiod, debounce * 1000);
 		if (ret < 0 && info->id_gpiod)
 			gpiod_set_debounce(info->vbus_gpiod, 0);
 	}
 	if (ret < 0)
-		info->debounce_jiffies = msecs_to_jiffies(USB_GPIO_DEBOUNCE_MS);
+		info->debounce_jiffies = msecs_to_jiffies(debounce);
 
 	INIT_DELAYED_WORK(&info->wq_detcable, usb_extcon_detect_cable);
 
-- 
1.9.1


  parent reply	other threads:[~2015-04-02 13:14 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-02 13:13 [PATCH v3 0/4] extcon: usb-gpio: fixes and improvements Robert Baldyga
2015-04-02 13:13 ` [PATCH v3 1/4] extcon: usb-gpio: register extcon device before IRQ registration Robert Baldyga
2015-04-03  0:09   ` Chanwoo Choi
2015-04-02 13:13 ` [PATCH v3 2/4] extcon: usb-gpio: add support for VBUS detection Robert Baldyga
2015-04-02 14:02   ` Roger Quadros
2015-04-02 14:02     ` Roger Quadros
2015-04-09  2:12   ` Chanwoo Choi
2015-04-09  2:12     ` Chanwoo Choi
2015-04-09  7:57     ` Robert Baldyga
2015-04-09  9:07       ` Chanwoo Choi
2015-04-09  9:07         ` Chanwoo Choi
2015-04-09  9:24         ` Robert Baldyga
2015-04-09  9:59           ` Roger Quadros
2015-04-09  9:59             ` Roger Quadros
2015-04-09 10:18             ` Robert Baldyga
2015-04-10  7:39             ` Chanwoo Choi
2015-04-10  7:17           ` Chanwoo Choi
2015-04-10  7:17             ` Chanwoo Choi
2015-04-10  7:45             ` Robert Baldyga
2015-04-10  8:10               ` Chanwoo Choi
2015-04-10  8:46                 ` Robert Baldyga
2015-04-10  9:18                   ` Chanwoo Choi
2015-04-10  9:42                     ` Robert Baldyga
2015-04-14 10:01                     ` Roger Quadros
2015-04-14 10:01                       ` Roger Quadros
2015-04-14 10:02                       ` Roger Quadros
2015-04-14 10:02                         ` Roger Quadros
2015-04-14 10:31                         ` Chanwoo Choi
2015-04-14 10:31                           ` Chanwoo Choi
2015-04-14 10:38                           ` Roger Quadros
2015-04-14 10:38                             ` Roger Quadros
2015-04-14 11:29                             ` Chanwoo Choi
2015-04-15  3:27                               ` Peter Chen
2015-04-15  3:27                                 ` Peter Chen
2015-04-15  7:50                                 ` Roger Quadros
2015-04-15  7:50                                   ` Roger Quadros
2015-04-15  9:26                                   ` Chanwoo Choi
2015-04-16  1:59                                     ` Peter Chen
2015-04-16  1:59                                       ` Peter Chen
2015-04-16  7:00                                       ` Chanwoo Choi
2015-04-16  7:13                                         ` Ivan T. Ivanov
2015-04-16  7:13                                           ` Ivan T. Ivanov
2015-04-16  7:59                                           ` Chanwoo Choi
2015-04-16  7:59                                             ` Chanwoo Choi
2015-04-16  8:01                                             ` Peter Chen
2015-04-16  8:01                                               ` Peter Chen
2015-04-16  8:26                                               ` Chanwoo Choi
2015-04-30  7:32                                                 ` Roger Quadros
2015-04-30  7:32                                                   ` Roger Quadros
2015-04-30  7:55                                                   ` Chanwoo Choi
2015-04-30  8:04                                                     ` Roger Quadros
2015-04-30  8:04                                                       ` Roger Quadros
2015-04-16  7:59                                           ` Peter Chen
2015-04-16  7:59                                             ` Peter Chen
2015-04-16  7:16                                         ` Roger Quadros
2015-04-16  7:16                                           ` Roger Quadros
2015-04-02 13:13 ` Robert Baldyga [this message]
2015-04-02 13:13 ` [PATCH v3 4/4] Documentation: extcon: usb-gpio: update usb-gpio binding description Robert Baldyga

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1427980385-21285-4-git-send-email-r.baldyga@samsung.com \
    --to=r.baldyga@samsung.com \
    --cc=cw00.choi@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=myungjoo.ham@samsung.com \
    --cc=rogerq@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.