All of lore.kernel.org
 help / color / mirror / Atom feed
From: yu.dai@intel.com
To: intel-gfx@lists.freedesktop.org
Cc: Sagar Kamble <sagar.a.kamble@intel.com>
Subject: [PATCH v2 17/18] drm/i915: Taking forcewake during GuC load.
Date: Fri,  3 Apr 2015 11:08:43 -0700	[thread overview]
Message-ID: <1428084524-28437-18-git-send-email-yu.dai@intel.com> (raw)
In-Reply-To: <1428084524-28437-1-git-send-email-yu.dai@intel.com>

From: Sagar Kamble <sagar.a.kamble@intel.com>

The firmware loader will use GuC DMA engine to move data from
ggtt to WOPCM. Need to take forcewake before GuC loading.

Issue: VIZ-4884
Change-Id: Ie422fc1e122933b161ff63cab23622197e6bba54
Signed-off-by: Sagar Kamble <sagar.a.kamble@intel.com>
---
 drivers/gpu/drm/i915/intel_guc_loader.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/gpu/drm/i915/intel_guc_loader.c b/drivers/gpu/drm/i915/intel_guc_loader.c
index 3a33618..2edf329 100644
--- a/drivers/gpu/drm/i915/intel_guc_loader.c
+++ b/drivers/gpu/drm/i915/intel_guc_loader.c
@@ -338,6 +338,7 @@ static int guc_load_ucode(struct drm_device *dev)
 	int ret;
 
 	WARN_ON(!mutex_is_locked(&dev->struct_mutex));
+	intel_uncore_forcewake_get(dev_priv, FORCEWAKE_ALL);
 
 	ret = i915_gem_obj_ggtt_pin(guc_fw->uc_fw_obj, 0, 0);
 	if (ret)
@@ -386,6 +387,8 @@ out:
 	if (pinned)
 		i915_gem_object_ggtt_unpin(guc_fw->uc_fw_obj);
 
+	intel_uncore_forcewake_put(dev_priv, FORCEWAKE_ALL);
+
 	return ret;
 }
 
-- 
1.9.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2015-04-03 18:10 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-03 18:08 [PATCH v2 00/18] *** Command submission via GuC for SKL *** yu.dai
2015-04-03 18:08 ` [PATCH v2 01/18] drm/i915: Add guc firmware interface headers yu.dai
2015-04-03 18:08 ` [PATCH v2 02/18] drm/i915: Add i915_gem_object_write() to i915_gem.c yu.dai
2015-04-03 18:08 ` [PATCH v2 03/18] drm/i915: Unified firmware loading mechanism yu.dai
2015-04-03 18:08 ` [PATCH v2 04/18] drm/i915: GuC firmware loader yu.dai
2015-04-03 18:08 ` [PATCH v2 05/18] drm/i915: Add firmware version check yu.dai
2015-04-03 18:08 ` [PATCH v2 06/18] drm/i915: Defer default hardware context initialisation until first open yu.dai
2015-04-03 18:08 ` [PATCH v2 07/18] drm/i915: Move execlists defines from .c to .h yu.dai
2015-04-03 18:08 ` [PATCH v2 08/18] drm/i915: Make several execlist helper functions external yu.dai
2015-04-03 18:08 ` [PATCH v2 09/18] drm/i915: Add functions to allocate / release gem obj for GuC yu.dai
2015-04-03 18:08 ` [PATCH v2 10/18] drm/i915: Functions to support command submission via GuC yu.dai
2015-04-03 18:08 ` [PATCH v2 11/18] drm/i915: Integration of GuC client yu.dai
2015-04-03 18:08 ` [PATCH v2 12/18] drm/i915: Interrupt routing for GuC scheduler yu.dai
2015-04-03 18:08 ` [PATCH v2 13/18] drm/i915: Enable commands submission via GuC yu.dai
2015-04-03 18:08 ` [PATCH v2 14/18] drm/i915: debugfs of GuC status yu.dai
2015-04-03 18:08 ` [PATCH v2 15/18] drm/i915: Enable GuC firmware log yu.dai
2015-04-03 18:08 ` [PATCH v2 16/18] drm/i915: Ring Context allocating for GuC yu.dai
2015-04-03 18:08 ` yu.dai [this message]
2015-04-03 18:08 ` [PATCH v2 18/18] Documentation/drm: kerneldoc " yu.dai
2015-04-09 13:24   ` shuang.he
2015-04-09 13:28     ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1428084524-28437-18-git-send-email-yu.dai@intel.com \
    --to=yu.dai@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=sagar.a.kamble@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.