From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chen Baozi Subject: [PATCH] xen/arm64: Avoid sending SGI when kicking secondary cpus with spin_table Date: Tue, 7 Apr 2015 15:33:52 +0800 Message-ID: <1428392032-11551-1-git-send-email-cbz@baozis.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: xen-devel@lists.xen.org Cc: Chen Baozi , julien.grall@linaro.org, ian.campbell@citrix.com List-Id: xen-devel@lists.xenproject.org From: Chen Baozi On arm64, either firmware or xen's smp_up_cpu gate uses WFE on secondary cpus to stand-by when booting. Thus, using SEV is enough for the boot cpu to kick other secondaries. Further more, the current implementation of cpu_up_send_sgi would pass a NULL cpumask pointer to send_SGI, which then lead a data fault on GICv3 send_SGI implementation. Signed-off-by: Chen Baozi --- xen/arch/arm/arm64/smpboot.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/arm/arm64/smpboot.c b/xen/arch/arm/arm64/smpboot.c index 341cc77..62e6abb 100644 --- a/xen/arch/arm/arm64/smpboot.c +++ b/xen/arch/arm/arm64/smpboot.c @@ -38,7 +38,7 @@ static int __init smp_spin_table_cpu_up(int cpu) sev(); - return cpu_up_send_sgi(cpu); + return 0; } static void __init smp_spin_table_init(int cpu, struct dt_device_node *dn) -- 2.1.4