From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [RFC PATCH 2/7] Xen: x86: print max usable RMID during init Date: Tue, 7 Apr 2015 10:11:42 +0000 Message-ID: <1428401500.5671.20.camel@citrix.com> References: <20150404020423.22875.23590.stgit@Solace.station> <20150404021432.22875.34441.stgit@Solace.station> <20150406134830.GD12596@l.oracle.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0555713983902442732==" Return-path: In-Reply-To: <20150406134830.GD12596@l.oracle.com> Content-Language: en-US List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: "konrad.wilk@oracle.com" Cc: Wei Liu , Ian Campbell , Andrew Cooper , George Dunlap , "xen-devel@lists.xen.org" , "JBeulich@suse.com" , "chao.p.peng@linux.intel.com" List-Id: xen-devel@lists.xenproject.org --===============0555713983902442732== Content-Language: en-US Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-sjj8Tr8E8GFEnrCA61ma" --=-sjj8Tr8E8GFEnrCA61ma Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, 2015-04-06 at 09:48 -0400, Konrad Rzeszutek Wilk wrote: > On Sat, Apr 04, 2015 at 04:14:33AM +0200, Dario Faggioli wrote: > > diff --git a/xen/arch/x86/psr.c b/xen/arch/x86/psr.c > > index c902625..0f2a6ce 100644 > > --- a/xen/arch/x86/psr.c > > +++ b/xen/arch/x86/psr.c > > @@ -111,7 +111,8 @@ static void __init init_psr_cmt(unsigned int rmid_m= ax) > > for ( rmid =3D 1; rmid <=3D psr_cmt->rmid_max; rmid++ ) > > psr_cmt->rmid_to_dom[rmid] =3D DOMID_INVALID; > > =20 > > - printk(XENLOG_INFO "Cache Monitoring Technology enabled\n"); > > + printk(XENLOG_INFO "Cache Monitoring Technology enabled, RMIDs: %u= \n", >=20 > max RMID: ? >=20 I considered it, but don't like it. IMO 'max' tells something about the values one can use as RMIDs, not about the fact that they are a limited resource. Perhaps something like "available RMIDs:" or "total nr. of RMIDs" ? Thanks and Regards, Dario --=-sjj8Tr8E8GFEnrCA61ma Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEABECAAYFAlUjrVwACgkQk4XaBE3IOsTvkwCfb9xnd+f3tOdfSNXpxSAUKnkQ B/IAnA1mshGRU9vhMTufnmhOq1kqkJZs =YPP5 -----END PGP SIGNATURE----- --=-sjj8Tr8E8GFEnrCA61ma-- --===============0555713983902442732== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============0555713983902442732==--