All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Márcio Almada" <marcio.web2@gmail.com>
To: git@vger.kernel.org
Subject: [PATCH] fix global bash variable on __gitcompappend
Date: Wed,  8 Apr 2015 02:45:57 -0300	[thread overview]
Message-ID: <1428471958-12339-1-git-send-email-marcio3w@gmail.com> (raw)

Hi,

This is how to reproduce the bug:

```
git checkout [tab-tab]
echo $x # outputs the name of the last branch on completion list
```

Or more directly:

```
__gitcompappend "something"
echo $x # outputs 'something'
```

Might not be a big deal, but it's annoying to know that `$x` is lurking.

Márcio Almada (1):
  fix global bash variable leak on __gitcompappend

 contrib/completion/git-completion.bash | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
1.9.3

             reply	other threads:[~2015-04-08  5:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-08  5:45 Márcio Almada [this message]
2015-04-08  5:45 ` [PATCH] fix global bash variable leak on __gitcompappend Márcio Almada
2015-04-09  3:56   ` Junio C Hamano
2015-04-09  8:55     ` SZEDER Gábor
2015-04-09 13:52     ` Marcio Almada
2015-04-09 19:26       ` Eric Sunshine

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1428471958-12339-1-git-send-email-marcio3w@gmail.com \
    --to=marcio.web2@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.