From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wei Liu Subject: [PATCH v2] libxl: check return value of libxl_vcpu_setaffinity Date: Wed, 8 Apr 2015 17:05:24 +0100 Message-ID: <1428509124-9283-1-git-send-email-wei.liu2@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: xen-devel@lists.xen.org Cc: Ian Jackson , andrew.cooper3@citrix.com, Dario Faggioli , Wei Liu , Ian Campbell List-Id: xen-devel@lists.xenproject.org That function can fail. Signed-off-by: Wei Liu Cc: Ian Campbell Cc: Ian Jackson Cc: Dario Faggioli --- v2: add missing `}'. --- tools/libxl/libxl_dom.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/tools/libxl/libxl_dom.c b/tools/libxl/libxl_dom.c index a88db69..8021ca6 100644 --- a/tools/libxl/libxl_dom.c +++ b/tools/libxl/libxl_dom.c @@ -468,8 +468,13 @@ static int set_vnuma_affinity(libxl__gc *gc, uint32_t domid, goto out; } - libxl_for_each_set_bit(j, v->vcpus) - libxl_set_vcpuaffinity(CTX, domid, j, NULL, &cpumap); + libxl_for_each_set_bit(j, v->vcpus) { + rc = libxl_set_vcpuaffinity(CTX, domid, j, NULL, &cpumap); + if (rc) { + LOG(ERROR, "Can't set cpu affinity for %d", j); + goto out; + } + } } out: -- 1.9.1