From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wei Liu Subject: [PATCH v2 2/4] libxenstat: YAJL_GET_STRING may return NULL Date: Wed, 8 Apr 2015 17:08:20 +0100 Message-ID: <1428509302-10081-3-git-send-email-wei.liu2@citrix.com> References: <1428509302-10081-1-git-send-email-wei.liu2@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1428509302-10081-1-git-send-email-wei.liu2@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: xen-devel@lists.xen.org Cc: Ian Jackson , andrew.cooper3@citrix.com, Wei Liu , Ian Campbell , Charles Arnold List-Id: xen-devel@lists.xenproject.org Passing NULL to strcmp can cause segmentation fault. Continue in that case. Signed-off-by: Wei Liu Cc: Ian Campbell Cc: Ian Jackson Cc: Charles Arnold Reviewed-by: Andrew Cooper Acked-by: Ian Jackson --- tools/xenstat/libxenstat/src/xenstat_qmp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/xenstat/libxenstat/src/xenstat_qmp.c b/tools/xenstat/libxenstat/src/xenstat_qmp.c index 10ae104..aad15c8 100644 --- a/tools/xenstat/libxenstat/src/xenstat_qmp.c +++ b/tools/xenstat/libxenstat/src/xenstat_qmp.c @@ -110,7 +110,7 @@ static char *qmp_get_block_image(xenstat_node *node, char *qmp_devname, int qfd) ptr[0] = qblock[QMP_BLOCK_DEVICE]; /* "device" */ if ((dev_obj = yajl_tree_get(n, ptr, yajl_t_any)) != NULL) { tmp = YAJL_GET_STRING(dev_obj); - if (strcmp(qmp_devname, tmp)) + if (!tmp || strcmp(qmp_devname, tmp)) continue; } else -- 1.9.1