From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932226AbbDHUKu (ORCPT ); Wed, 8 Apr 2015 16:10:50 -0400 Received: from g4t3425.houston.hp.com ([15.201.208.53]:5053 "EHLO g4t3425.houston.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754710AbbDHUKj (ORCPT ); Wed, 8 Apr 2015 16:10:39 -0400 Message-ID: <1428523835.3506.11.camel@j-VirtualBox> Subject: Re: [PATCH 0/2] locking: Simplify mutex and rwsem spinning code From: Jason Low To: Davidlohr Bueso Cc: Peter Zijlstra , Ingo Molnar , Linus Torvalds , Tim Chen , Aswin Chandramouleeswaran , LKML , jason.low2@hp.com Date: Wed, 08 Apr 2015 13:10:35 -0700 In-Reply-To: <1428522581.11099.7.camel@stgolabs.net> References: <1428521960-5268-1-git-send-email-jason.low2@hp.com> <1428522581.11099.7.camel@stgolabs.net> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2015-04-08 at 12:49 -0700, Davidlohr Bueso wrote: > On Wed, 2015-04-08 at 12:39 -0700, Jason Low wrote: > > This patchset applies on top of tip. > > > > Jason Low (2): > > locking/mutex: Further refactor mutex_spin_on_owner() > > locking/rwsem: Use a return variable in rwsem_spin_on_owner() > > > > kernel/locking/mutex.c | 14 ++++---------- > > kernel/locking/rwsem-xadd.c | 25 ++++++++++++------------- > > 2 files changed, 16 insertions(+), 23 deletions(-) > > Meh. Personally I wouldn't mid leaving these files alone for a change, > the code is already pretty readable imho. Of course its a matter of > taste, so I won't argue. I agree that it's quite readable now too, though Peter and Ingo seems like they would prefer these changes :) https://lkml.org/lkml/2015/3/7/46 https://lkml.org/lkml/2015/3/16/102