Re: [PATCH 5/6] ipr: AF DASD raw mode implementation in ipr driver

From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Brian King <brking@linux.vnet.ibm.com>
Cc: hch@lst.de, linux-scsi@vger.kernel.org,
	wenxiong@linux.vnet.ibm.com, kreling@linux.vnet.ibm.com,
	krisman@linux.vnet.ibm.com
Subject: Re: [PATCH 5/6] ipr: AF DASD raw mode implementation in ipr driver
Date: Thu, 09 Apr 2015 14:17:39 -0700	[thread overview]
Message-ID: <1428614259.2448.3.camel@HansenPartnership.com> (raw)
In-Reply-To: <201503261623.t2QGNxP3021634@d03av04.boulder.ibm.com>

On Thu, 2015-03-26 at 11:23 -0500, Brian King wrote:
> From: Wen Xiong <wenxiong@linux.vnet.ibm.com>
> 
> This patch implements raw mode support for AF DASD in ipr driver
> which allows for tools to send commands directly to physical
> devices which are members of RAID arrays when enabled in the firmware.
> 
> Signed-off-by: Wen Xiong<wenxiong@linux.vnet.ibm.com>
> Signed-off-by: Brian King <brking@linux.vnet.ibm.com>
> ---
> 
>  drivers/scsi/ipr.c |   85 +++++++++++++++++++++++++++++++++++++++++++++++++++++
>  drivers/scsi/ipr.h |    3 +
>  2 files changed, 88 insertions(+)
> 
> diff -puN drivers/scsi/ipr.c~ipr_sispipe drivers/scsi/ipr.c
> --- linux/drivers/scsi/ipr.c~ipr_sispipe	2015-03-26 10:53:55.540578199 -0500
> +++ linux-bjking1/drivers/scsi/ipr.c	2015-03-26 10:57:00.570080498 -0500
[...]
> @@ -6152,6 +6228,13 @@ static void ipr_erp_start(struct ipr_ioa
>  		break;
>  	case IPR_IOASC_NR_INIT_CMD_REQUIRED:
>  		break;
> +	case IPR_IOASC_IR_NON_OPTIMIZED:
> +		if (res->raw_mode){

Missing space here ... checkpatch would have picked this up; please use
it.

James