All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gustavo Padovan <gustavo@padovan.org>
To: linux-samsung-soc@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org, inki.dae@samsung.com,
	jy0922.shim@samsung.com,
	Gustavo Padovan <gustavo.padovan@collabora.co.uk>
Subject: [PATCH] drm/exynos: remove unnecessary calls to disable_plane()
Date: Fri, 10 Apr 2015 14:57:06 -0400	[thread overview]
Message-ID: <1428692226-7157-1-git-send-email-gustavo@padovan.org> (raw)
In-Reply-To: <1428084583-14616-12-git-send-email-gustavo@padovan.org>

From: Gustavo Padovan <gustavo.padovan@collabora.co.uk>

The planes are already disabled by the drm_atomic_helper_commit() code
so we don't need to disable the in these two places.

Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
---
 drivers/gpu/drm/exynos/exynos_drm_crtc.c    | 11 -----------
 drivers/gpu/drm/exynos/exynos_drm_encoder.c |  8 --------
 2 files changed, 19 deletions(-)

diff --git a/drivers/gpu/drm/exynos/exynos_drm_crtc.c b/drivers/gpu/drm/exynos/exynos_drm_crtc.c
index 519c569..9bf25ff 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_crtc.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_crtc.c
@@ -47,8 +47,6 @@ static void exynos_drm_crtc_enable(struct drm_crtc *crtc)
 static void exynos_drm_crtc_disable(struct drm_crtc *crtc)
 {
 	struct exynos_drm_crtc *exynos_crtc = to_exynos_crtc(crtc);
-	struct drm_plane *plane;
-	int ret;
 
 	if (!exynos_crtc->enabled)
 		return;
@@ -64,15 +62,6 @@ static void exynos_drm_crtc_disable(struct drm_crtc *crtc)
 		exynos_crtc->ops->dpms(exynos_crtc, DRM_MODE_DPMS_OFF);
 
 	exynos_crtc->enabled = false;
-
-	drm_for_each_legacy_plane(plane, &crtc->dev->mode_config.plane_list) {
-		if (plane->crtc != crtc)
-			continue;
-
-		ret = plane->funcs->disable_plane(plane);
-		if (ret)
-			DRM_ERROR("Failed to disable plane %d\n", ret);
-	}
 }
 
 static bool
diff --git a/drivers/gpu/drm/exynos/exynos_drm_encoder.c b/drivers/gpu/drm/exynos/exynos_drm_encoder.c
index 0648ba4..7b89fd5 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_encoder.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_encoder.c
@@ -81,17 +81,9 @@ static void exynos_drm_encoder_disable(struct drm_encoder *encoder)
 {
 	struct exynos_drm_encoder *exynos_encoder = to_exynos_encoder(encoder);
 	struct exynos_drm_display *display = exynos_encoder->display;
-	struct drm_plane *plane;
-	struct drm_device *dev = encoder->dev;
 
 	if (display->ops->dpms)
 		display->ops->dpms(display, DRM_MODE_DPMS_OFF);
-
-	/* all planes connected to this encoder should be also disabled. */
-	drm_for_each_legacy_plane(plane, &dev->mode_config.plane_list) {
-		if (plane->crtc && (plane->crtc == encoder->crtc))
-			plane->funcs->disable_plane(plane);
-	}
 }
 
 static struct drm_encoder_helper_funcs exynos_encoder_helper_funcs = {
-- 
2.1.0

  parent reply	other threads:[~2015-04-10 18:57 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-03 18:09 [PATCH -v3 00/11] drm/exynos: Add atomic modesetting support Gustavo Padovan
2015-04-03 18:09 ` [PATCH -v3 01/11] drm/exynos: atomic phase 1: use drm_plane_helper_update() Gustavo Padovan
2015-04-03 18:09 ` [PATCH -v3 02/11] drm/exynos: atomic phase 1: use drm_plane_helper_disable() Gustavo Padovan
2015-04-03 18:09 ` [PATCH -v3 03/11] drm/exynos: atomic phase 1: add .mode_set_nofb() callback Gustavo Padovan
2015-04-03 18:09 ` [PATCH -v3 04/11] drm/exynos: atomic phase 2: wire up state reset(), duplicate() and destroy() Gustavo Padovan
2015-04-03 18:09 ` [PATCH -v3 05/11] drm/exynos: atomic phase 2: keep track of framebuffer pointer Gustavo Padovan
2015-04-03 18:09 ` [PATCH -v3 06/11] drm/exynos: atomic phase 3: atomic updates of planes Gustavo Padovan
2015-04-03 18:09 ` [PATCH -v3 07/11] drm/exynos: atomic phase 3: use atomic .set_config helper Gustavo Padovan
2015-04-03 18:09 ` [PATCH -v3 08/11] drm/exynos: atomic phase 3: convert page flips Gustavo Padovan
2015-04-03 18:09 ` [PATCH -v3 09/11] drm/exynos: remove exported functions from exynos_drm_plane Gustavo Padovan
2015-04-03 18:09 ` [PATCH -v3 10/11] drm/exynos: don't disable unused functions at init Gustavo Padovan
2015-04-03 18:09 ` [PATCH -v3 11/11] drm/exynos: atomic dpms support Gustavo Padovan
2015-04-05 14:42   ` Inki Dae
2015-04-06 18:26     ` Gustavo Padovan
2015-04-07  7:22       ` Joonyoung Shim
2015-04-07 19:56         ` [PATCH v4] " Gustavo Padovan
2015-04-10 18:57   ` Gustavo Padovan [this message]
2015-04-13  6:32     ` [PATCH] drm/exynos: remove unnecessary calls to disable_plane() Joonyoung Shim
2015-04-13 17:35       ` Gustavo Padovan
2015-04-06 10:46 ` [PATCH -v3 00/11] drm/exynos: Add atomic modesetting support Inki Dae
2015-04-06 15:44   ` Inki Dae
2015-04-07  7:06     ` Inki Dae
2015-04-07 11:14       ` Inki Dae
2015-04-07 17:24         ` Gustavo Padovan
2015-04-07 18:39       ` Gustavo Padovan
2015-04-07 19:14         ` Tobias Jakobi
2015-04-08 15:14         ` Inki Dae
2015-04-09  7:04           ` Joonyoung Shim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1428692226-7157-1-git-send-email-gustavo@padovan.org \
    --to=gustavo@padovan.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gustavo.padovan@collabora.co.uk \
    --cc=inki.dae@samsung.com \
    --cc=jy0922.shim@samsung.com \
    --cc=linux-samsung-soc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.