From mboxrd@z Thu Jan 1 00:00:00 1970 From: Scott Wood Subject: Re: [PATCH] powerpc/dts: Update the core cluster PLL node(s) Date: Tue, 14 Apr 2015 15:21:08 -0500 Message-ID: <1429042868.22867.689.camel@freescale.com> References: <1429005306-24544-1-git-send-email-igal.liberman@freescale.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1429005306-24544-1-git-send-email-igal.liberman@freescale.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linuxppc-dev-bounces+glppe-linuxppc-embedded-2=m.gmane.org@lists.ozlabs.org Sender: "Linuxppc-dev" To: "Igal.Liberman" Cc: devicetree@vger.kernel.org, linuxppc-dev@lists.ozlabs.org List-Id: devicetree@vger.kernel.org T24gVHVlLCAyMDE1LTA0LTE0IGF0IDEyOjU1ICswMzAwLCBJZ2FsLkxpYmVybWFuIHdyb3RlOgo+ IEZyb206IElnYWwgTGliZXJtYW4gPElnYWwuTGliZXJtYW5AZnJlZXNjYWxlLmNvbT4KPiAKPiBU aGlzIHBhdGNoIHJlcGxhY2VzIHRoZSBmb2xsb3dpbmc6Cj4gCWh0dHBzOi8vcGF0Y2h3b3JrLm96 bGFicy5vcmcvcGF0Y2gvNDI3NjY0Lwo+IAo+IFRoaXMgcGF0Y2ggaXMgZGVzY3JpYmVkIGJ5IHRo ZSBmb2xsb3dpbmcgYmluZGluZyBkb2N1bWVudCB1cGRhdGU6Cj4gCWh0dHBzOi8vcGF0Y2h3b3Jr Lm96bGFicy5vcmcvcGF0Y2gvNDYxMTUwLwo+IAo+IFNpZ25lZC1vZmYtYnk6IElnYWwgTGliZXJt YW4gPElnYWwuTGliZXJtYW5AZnJlZXNjYWxlLmNvbT4KPiAtLS0KPiAgYXJjaC9wb3dlcnBjL2Jv b3QvZHRzL2ZzbC9xb3JpcS1jbG9ja2dlbjIuZHRzaSB8ICAgIDYgKysrKy0tCj4gIDEgZmlsZSBj aGFuZ2VkLCA0IGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBh L2FyY2gvcG93ZXJwYy9ib290L2R0cy9mc2wvcW9yaXEtY2xvY2tnZW4yLmR0c2kgYi9hcmNoL3Bv d2VycGMvYm9vdC9kdHMvZnNsL3FvcmlxLWNsb2NrZ2VuMi5kdHNpCj4gaW5kZXggNDhlMGI2ZS4u N2UxZjA3NCAxMDA2NDQKPiAtLS0gYS9hcmNoL3Bvd2VycGMvYm9vdC9kdHMvZnNsL3FvcmlxLWNs b2NrZ2VuMi5kdHNpCj4gKysrIGIvYXJjaC9wb3dlcnBjL2Jvb3QvZHRzL2ZzbC9xb3JpcS1jbG9j a2dlbjIuZHRzaQo+IEBAIC00OSwxNCArNDksMTYgQEAgZ2xvYmFsLXV0aWxpdGllc0BlMTAwMCB7 Cj4gIAkJcmVnID0gPDB4ODAwIDB4ND47Cj4gIAkJY29tcGF0aWJsZSA9ICJmc2wscW9yaXEtY29y ZS1wbGwtMi4wIjsKPiAgCQljbG9ja3MgPSA8JnN5c2Nsaz47Cj4gLQkJY2xvY2stb3V0cHV0LW5h bWVzID0gInBsbDAiLCAicGxsMC1kaXYyIiwgInBsbDAtZGl2NCI7Cj4gKwkJY2xvY2stb3V0cHV0 LW5hbWVzID0gInBsbDAiLCAicGxsMC1kaXYyIiwgInBsbDAtZGl2MyIsCj4gKwkJCQkgICAgICAi cGxsMC1kaXY0IjsKPiAgCX07Cj4gIAlwbGwxOiBwbGwxQDgyMCB7Cj4gIAkJI2Nsb2NrLWNlbGxz ID0gPDE+Owo+ICAJCXJlZyA9IDwweDgyMCAweDQ+Owo+ICAJCWNvbXBhdGlibGUgPSAiZnNsLHFv cmlxLWNvcmUtcGxsLTIuMCI7Cj4gIAkJY2xvY2tzID0gPCZzeXNjbGs+Owo+IC0JCWNsb2NrLW91 dHB1dC1uYW1lcyA9ICJwbGwxIiwgInBsbDEtZGl2MiIsICJwbGwxLWRpdjQiOwo+ICsJCWNsb2Nr LW91dHB1dC1uYW1lcyA9ICJwbGwxIiwgInBsbDEtZGl2MiIsICJwbGwxLWRpdjMiLAo+ICsJCQkJ ICAgICAgInBsbDEtZGl2NCI7CgpXYWl0LCBzbyBpZiB0aGUgZHJpdmVyIGltcGxlbWVudHMgdGhl IGJpbmRpbmcgeW91IHN1Ym1pdHRlZCwgeW91J2xsCmJyZWFrIGNvbXBhdGliaWxpdHkgd2l0aCB0 aGVzZSBvbGRlciBkZXZpY2UgdHJlZXMuLi4KCkkgdGhpbmsgd2UgbmVlZCB0byBqdXN0IGFjY2Vw dCB0aGUgdWdseSBjb3VudC10aGUtY2xvY2stbmFtZXMgYXBwcm9hY2gKYW5kIGRvY3VtZW50IGl0 LgoKLVNjb3R0CgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KTGludXhwcGMtZGV2IG1haWxpbmcgbGlzdApMaW51eHBwYy1kZXZAbGlzdHMub3psYWJzLm9y ZwpodHRwczovL2xpc3RzLm96bGFicy5vcmcvbGlzdGluZm8vbGludXhwcGMtZGV2 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from na01-bn1-obe.outbound.protection.outlook.com (mail-bn1on0114.outbound.protection.outlook.com [157.56.110.114]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id EE0F21A0B8D for ; Wed, 15 Apr 2015 06:21:29 +1000 (AEST) Message-ID: <1429042868.22867.689.camel@freescale.com> Subject: Re: [PATCH] powerpc/dts: Update the core cluster PLL node(s) From: Scott Wood To: Igal.Liberman Date: Tue, 14 Apr 2015 15:21:08 -0500 In-Reply-To: <1429005306-24544-1-git-send-email-igal.liberman@freescale.com> References: <1429005306-24544-1-git-send-email-igal.liberman@freescale.com> Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Cc: devicetree@vger.kernel.org, linuxppc-dev@lists.ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tue, 2015-04-14 at 12:55 +0300, Igal.Liberman wrote: > From: Igal Liberman > > This patch replaces the following: > https://patchwork.ozlabs.org/patch/427664/ > > This patch is described by the following binding document update: > https://patchwork.ozlabs.org/patch/461150/ > > Signed-off-by: Igal Liberman > --- > arch/powerpc/boot/dts/fsl/qoriq-clockgen2.dtsi | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/arch/powerpc/boot/dts/fsl/qoriq-clockgen2.dtsi b/arch/powerpc/boot/dts/fsl/qoriq-clockgen2.dtsi > index 48e0b6e..7e1f074 100644 > --- a/arch/powerpc/boot/dts/fsl/qoriq-clockgen2.dtsi > +++ b/arch/powerpc/boot/dts/fsl/qoriq-clockgen2.dtsi > @@ -49,14 +49,16 @@ global-utilities@e1000 { > reg = <0x800 0x4>; > compatible = "fsl,qoriq-core-pll-2.0"; > clocks = <&sysclk>; > - clock-output-names = "pll0", "pll0-div2", "pll0-div4"; > + clock-output-names = "pll0", "pll0-div2", "pll0-div3", > + "pll0-div4"; > }; > pll1: pll1@820 { > #clock-cells = <1>; > reg = <0x820 0x4>; > compatible = "fsl,qoriq-core-pll-2.0"; > clocks = <&sysclk>; > - clock-output-names = "pll1", "pll1-div2", "pll1-div4"; > + clock-output-names = "pll1", "pll1-div2", "pll1-div3", > + "pll1-div4"; Wait, so if the driver implements the binding you submitted, you'll break compatibility with these older device trees... I think we need to just accept the ugly count-the-clock-names approach and document it. -Scott