From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH v2 1/2] vtpm: deep quote flags
Date: Wed, 15 Apr 2015 16:34:32 +0100
Message-ID: <1429112072.15516.329.camel@citrix.com>
References: <1429002534-8759-1-git-send-email-emilcondrea@gmail.com>
	<1429002534-8759-2-git-send-email-emilcondrea@gmail.com>
	<552E7EA0.6040709@tycho.nsa.gov>
	<CAAULxKKf79BtyempQOVmy49nHWWEQ3StYpRcEurwtzKj_2mwhw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <CAAULxKKf79BtyempQOVmy49nHWWEQ3StYpRcEurwtzKj_2mwhw@mail.gmail.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Emil Condrea <emilcondrea@gmail.com>
Cc: Daniel De Graaf <dgdegra@tycho.nsa.gov>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On Wed, 2015-04-15 at 18:09 +0300, Emil Condrea wrote:
> Thanks! Should it remove it and resend the patches ?

I'll do it on commit (which I'm about to do).

> 
> On Wed, Apr 15, 2015 at 6:07 PM, Daniel De Graaf
> <dgdegra@tycho.nsa.gov> wrote:
>         On 04/14/2015 05:08 AM, Emil Condrea wrote:
>                 Currently, the flags are not interpreted by vTPM. They
>                 are just
>                 packed and sent to vtpmmgr.
>                 
>                 Signed-off-by: Emil Condrea <emilcondrea@gmail.com>
>         
>         Acked-by: Daniel De Graaf <dgdegra@tycho.nsa.gov>
>         
>         [...]
>                 +-      res = TPM_DeepQuote(&nonce, &myPCR, &ptPCR,
>                 &req->auth1, &sigSize, &sig);
>                 ++      res = TPM_DeepQuote(&nonce, &myPCR, &ptPCR,
>                 &req->auth1, extraInfoFlags,
>                 ++              &quote_blob_size, &quote_blob);
>                 +       if (res != TPM_SUCCESS) return res;
>                 +-      rsp->paramSize = len = sigSize;
>                 ++              rsp->paramSize = len =
>                 quote_blob_size;
>         
>         There's an extra tab at the start of this line.
>         
>         _______________________________________________
>         Xen-devel mailing list
>         Xen-devel@lists.xen.org
>         http://lists.xen.org/xen-devel
> 
>