From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH] xen: arm: X-Gene Storm check GIC DIST address for EOI quirk Date: Wed, 15 Apr 2015 17:16:39 +0100 Message-ID: <1429114599.25195.4.camel@citrix.com> References: <1428310441-5412-1-git-send-email-pranavkumar@linaro.org> <55229C89.9080400@citrix.com> <5523B1A0.9040802@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <5523B1A0.9040802@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Julien Grall Cc: Stefano Stabellini , patches@apm.com, xen-devel@lists.xen.org, stefano.stabellini@citrix.com, christoffer.dall@linaro.org, Pranavkumar Sawargaonkar List-Id: xen-devel@lists.xenproject.org On Tue, 2015-04-07 at 11:29 +0100, Julien Grall wrote: > >> This would avoid to have this loop and rely on there is always only one > >> interrupt controller in the DT. > > > > That is true, however we do know that on this SoC there is only one GIC, > > so it might be acceptable to rely on this knowledge: this is already > > very platform specific code. > > If we keep the loop, I would add a comment on the above the loop > explaining that we rely on there is always only GIC. > > Although, I was wondering if we could simply rely on the node path to > get the DT node? If we know that all $OLD firmwares used the same path (or small set of paths) then that could work. Or the loop could be replaced with dt_find_interrupt_controller, passing the known compatible value for the systems in question. Ian.