From mboxrd@z Thu Jan 1 00:00:00 1970 From: Scott Wood Subject: Re: [v3] dt/bindings: qoriq-clock: Add binding for FMan clock mux Date: Wed, 15 Apr 2015 12:35:57 -0500 Message-ID: <1429119357.22867.724.camel@freescale.com> References: <1429008968-24707-1-git-send-email-igal.liberman@freescale.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1429008968-24707-1-git-send-email-igal.liberman@freescale.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linuxppc-dev-bounces+glppe-linuxppc-embedded-2=m.gmane.org@lists.ozlabs.org Sender: "Linuxppc-dev" To: "Igal.Liberman" Cc: devicetree@vger.kernel.org, linuxppc-dev@lists.ozlabs.org List-Id: devicetree@vger.kernel.org T24gVHVlLCAyMDE1LTA0LTE0IGF0IDEzOjU2ICswMzAwLCBJZ2FsLkxpYmVybWFuIHdyb3RlOgo+ IEZyb206IElnYWwgTGliZXJtYW4gPElnYWwuTGliZXJtYW5AZnJlZXNjYWxlLmNvbT4KPiAKPiB2 MzogQWRkcmVzc2VkIGZlZWRiYWNrIGZyb20gU2NvdHQ6Cj4gCS0gUmVtb3ZlZCBjbG9jayBzcGVj aWZpZXIgZGVzY3JpcHRpb24uCj4gCj4gdjI6IEFkZHJlc3NlZCBmZWVkYmFjayBmcm9tIFNjb3R0 Ogo+IAktIE1vdmVkIHRoZSAiZm1hbi1jbGstbXV4IiBjbG9jayBwcm92aWRlciBkZXRhaWxzCj4g CSAgdW5kZXIgImNsb2NrcyIgcHJvcGVydHkuCj4gCj4gU2lnbmVkLW9mZi1ieTogSWdhbCBMaWJl cm1hbiA8SWdhbC5MaWJlcm1hbkBmcmVlc2NhbGUuY29tPgo+IC0tLQo+ICAuLi4vZGV2aWNldHJl ZS9iaW5kaW5ncy9jbG9jay9xb3JpcS1jbG9jay50eHQgICAgICB8ICAgMTcgKysrKysrKysrKysr KysrLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDE1IGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0p Cj4gCj4gZGlmZiAtLWdpdCBhL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9jbG9j ay9xb3JpcS1jbG9jay50eHQgYi9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvY2xv Y2svcW9yaXEtY2xvY2sudHh0Cj4gaW5kZXggYjBkN2I3My4uMmJiM2IzOCAxMDA2NDQKPiAtLS0g YS9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvY2xvY2svcW9yaXEtY2xvY2sudHh0 Cj4gKysrIGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2Nsb2NrL3FvcmlxLWNs b2NrLnR4dAo+IEBAIC02NSw5ICs2NSwxMCBAQCBSZXF1aXJlZCBwcm9wZXJ0aWVzOgo+ICAJCUl0 IHRha2VzIHBhcmVudCdzIGNsb2NrLWZyZXF1ZW5jeSBhcyBpdHMgY2xvY2suCj4gIAkqICJmc2ws cW9yaXEtcGxhdGZvcm0tcGxsLTEuMCIgZm9yIHRoZSBwbGF0Zm9ybSBQTEwgY2xvY2sgKHYxLjAp Cj4gIAkqICJmc2wscW9yaXEtcGxhdGZvcm0tcGxsLTIuMCIgZm9yIHRoZSBwbGF0Zm9ybSBQTEwg Y2xvY2sgKHYyLjApCj4gKwkqICJmc2wsZm1hbi1jbGstbXV4IiBmb3IgdGhlIEZyYW1lIE1hbmFn ZXIgY2xvY2suCj4gIC0gI2Nsb2NrLWNlbGxzOiBGcm9tIGNvbW1vbiBjbG9jayBiaW5kaW5nLiBU aGUgbnVtYmVyIG9mIGNlbGxzIGluIGEKPiAtCWNsb2NrLXNwZWNpZmllci4gU2hvdWxkIGJlIDww PiBmb3IgImZzbCxxb3JpcS1zeXNjbGstWzEsMl0uMCIKPiAtCWNsb2Nrcywgb3IgPDE+IGZvciAi ZnNsLHFvcmlxLWNvcmUtcGxsLVsxLDJdLjAiIGNsb2Nrcy4KPiArCWNsb2NrLXNwZWNpZmllci4g U2hvdWxkIGJlIDwwPiBmb3IgImZzbCxxb3JpcS1zeXNjbGstWzEsMl0uMCIgYW5kCj4gKwkiZnNs LGZtYW4tY2xrLW11eCIgY2xvY2tzIG9yIDwxPiBmb3IgImZzbCxxb3JpcS1jb3JlLXBsbC1bMSwy XS4wIi4KPiAgCUZvciAiZnNsLHFvcmlxLWNvcmUtcGxsLTEuMCIgY2xvY2tzLCB0aGUgc2luZ2xl Cj4gIAljbG9jay1zcGVjaWZpZXIgY2VsbCBtYXkgdGFrZSB0aGUgZm9sbG93aW5nIHZhbHVlczoK PiAgCSogMCAtIGVxdWFsIHRvIHRoZSBQTEwgZnJlcXVlbmN5Cj4gQEAgLTE0NSw2ICsxNDYsMTgg QEAgRXhhbXBsZSBmb3IgY2xvY2sgYmxvY2sgYW5kIGNsb2NrIHByb3ZpZGVyOgo+ICAJCQljbG9j a3MgPSA8JnN5c2Nsaz47Cj4gIAkJCWNsb2NrLW91dHB1dC1uYW1lcyA9ICJwbGF0Zm9ybS1wbGwi LCAicGxhdGZvcm0tcGxsLWRpdjIiOwo+ICAJCX07Cj4gKwo+ICsJCWZtMGNsazogZm0wLWNsay1t dXggewo+ICsJCQkjY2xvY2stY2VsbHMgPSA8MD47Cj4gKwkJCXJlZyA9IDwweDEwIDQ+Cj4gKwkJ CWNvbXBhdGlibGUgPSAiZnNsLGZtYW4tY2xrLW11eCI7Cj4gKwkJCWNsb2NrcyA9IDwmcGxsMCAw PiwgPCZwbGwwIDE+LCA8JnBsbDAgMj4sIDwmcGxsMCAzPiwKPiArCQkJCSA8JnBsYXRmb3JtX3Bs bCAwPiwgPCZwbGwxIDE+LCA8JnBsbDEgMj47Cj4gKwkJCWNsb2NrLW5hbWVzID0gInBsbDAiLCAi cGxsMC1kaXYyIiwgInBsbDAtZGl2MyIsCj4gKwkJCQkgICAgICAicGxsMC1kaXY0IiwgInBsYXRm b3JtLXBsbCIsICJwbGwxLWRpdjIiLAo+ICsJCQkJICAgICAgInBsbDEtZGl2MyI7Cj4gKwkJCWNs b2NrLW91dHB1dC1uYW1lcyA9ICJmbTAtY2xrIjsKPiArCQl9Owo+ICAJfTsKPiAgfTsKPiAgCgpJ IGRvbid0IHNlZSB0aGlzIHJlZ2lzdGVyIGluIHRoZSBtYW51YWxzIGZvciBvbGRlciBEUEFBIGNo aXBzLCBzdWNoIGFzCnA0MDgwIG9yIHAzMDQxLiAgSXMgaXQgcHJlc2VudCBidXQgdW5kb2N1bWVu dGVkPyAgU2hvdWxkIEkgYmUgbG9va2luZwpzb21ld2hlcmUgb3RoZXIgdGhhbiAiQ2xvY2tpbmcg TWVtb3J5IE1hcCI/CgotU2NvdHQKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpMaW51eHBwYy1kZXYgbWFpbGluZyBsaXN0CkxpbnV4cHBjLWRldkBsaXN0 cy5vemxhYnMub3JnCmh0dHBzOi8vbGlzdHMub3psYWJzLm9yZy9saXN0aW5mby9saW51eHBwYy1k ZXY= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from na01-by2-obe.outbound.protection.outlook.com (mail-by2on0123.outbound.protection.outlook.com [207.46.100.123]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 7DBEF1A0143 for ; Thu, 16 Apr 2015 03:36:13 +1000 (AEST) Message-ID: <1429119357.22867.724.camel@freescale.com> Subject: Re: [v3] dt/bindings: qoriq-clock: Add binding for FMan clock mux From: Scott Wood To: Igal.Liberman Date: Wed, 15 Apr 2015 12:35:57 -0500 In-Reply-To: <1429008968-24707-1-git-send-email-igal.liberman@freescale.com> References: <1429008968-24707-1-git-send-email-igal.liberman@freescale.com> Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Cc: devicetree@vger.kernel.org, linuxppc-dev@lists.ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tue, 2015-04-14 at 13:56 +0300, Igal.Liberman wrote: > From: Igal Liberman > > v3: Addressed feedback from Scott: > - Removed clock specifier description. > > v2: Addressed feedback from Scott: > - Moved the "fman-clk-mux" clock provider details > under "clocks" property. > > Signed-off-by: Igal Liberman > --- > .../devicetree/bindings/clock/qoriq-clock.txt | 17 +++++++++++++++-- > 1 file changed, 15 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/clock/qoriq-clock.txt b/Documentation/devicetree/bindings/clock/qoriq-clock.txt > index b0d7b73..2bb3b38 100644 > --- a/Documentation/devicetree/bindings/clock/qoriq-clock.txt > +++ b/Documentation/devicetree/bindings/clock/qoriq-clock.txt > @@ -65,9 +65,10 @@ Required properties: > It takes parent's clock-frequency as its clock. > * "fsl,qoriq-platform-pll-1.0" for the platform PLL clock (v1.0) > * "fsl,qoriq-platform-pll-2.0" for the platform PLL clock (v2.0) > + * "fsl,fman-clk-mux" for the Frame Manager clock. > - #clock-cells: From common clock binding. The number of cells in a > - clock-specifier. Should be <0> for "fsl,qoriq-sysclk-[1,2].0" > - clocks, or <1> for "fsl,qoriq-core-pll-[1,2].0" clocks. > + clock-specifier. Should be <0> for "fsl,qoriq-sysclk-[1,2].0" and > + "fsl,fman-clk-mux" clocks or <1> for "fsl,qoriq-core-pll-[1,2].0". > For "fsl,qoriq-core-pll-1.0" clocks, the single > clock-specifier cell may take the following values: > * 0 - equal to the PLL frequency > @@ -145,6 +146,18 @@ Example for clock block and clock provider: > clocks = <&sysclk>; > clock-output-names = "platform-pll", "platform-pll-div2"; > }; > + > + fm0clk: fm0-clk-mux { > + #clock-cells = <0>; > + reg = <0x10 4> > + compatible = "fsl,fman-clk-mux"; > + clocks = <&pll0 0>, <&pll0 1>, <&pll0 2>, <&pll0 3>, > + <&platform_pll 0>, <&pll1 1>, <&pll1 2>; > + clock-names = "pll0", "pll0-div2", "pll0-div3", > + "pll0-div4", "platform-pll", "pll1-div2", > + "pll1-div3"; > + clock-output-names = "fm0-clk"; > + }; > }; > }; > I don't see this register in the manuals for older DPAA chips, such as p4080 or p3041. Is it present but undocumented? Should I be looking somewhere other than "Clocking Memory Map"? -Scott