From: Imre Deak <imre.deak@intel.com>
To: Animesh Manna <animesh.manna@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v4 1/8] drm/i915/skl: Add support to load SKL CSR firmware.
Date: Thu, 16 Apr 2015 12:21:57 +0300 [thread overview]
Message-ID: <1429176117.26416.15.camel@intel.com> (raw)
In-Reply-To: <1429174334-12089-2-git-send-email-animesh.manna@intel.com>
On to, 2015-04-16 at 14:22 +0530, Animesh Manna wrote:
> [...]
> +#include <linux/firmware.h>
> +#include "i915_drv.h"
> +#include "i915_reg.h"
> +
> +#define I915_CSR_SKL "i915/skl_dmc_ver1.bin"
The latest version on the FW download page is skl_dmc_ver4.bin as Damien
pointed out and skl_dmc_ver1.bin is not available there. So why did you
choose ver1? If ver4 is not compatible with the current driver code,
then ver1 must be made available too on the download page, otherwise we
should use here ver4.
The patch otherwise looks ok to me.
--Imre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-04-16 9:22 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-16 8:52 [PATCH v4 0/8] Enable DC states for skl Animesh Manna
2015-04-16 8:52 ` [PATCH v4 1/8] drm/i915/skl: Add support to load SKL CSR firmware Animesh Manna
2015-04-16 9:18 ` Damien Lespiau
2015-04-16 9:21 ` Imre Deak [this message]
2015-04-16 11:59 ` Animesh Manna
2015-04-16 11:25 ` Imre Deak
2015-04-16 14:23 ` Animesh Manna
2015-04-16 15:20 ` Imre Deak
2015-04-28 14:45 ` Imre Deak
2015-04-29 17:29 ` [PATCH v5 " Animesh Manna
2015-04-30 13:02 ` Imre Deak
2015-05-04 9:30 ` Daniel Vetter
2015-05-04 10:31 ` Imre Deak
2015-05-04 12:54 ` Daniel Vetter
2015-04-16 8:52 ` [PATCH v4 2/8] drm/i915/skl: Add DC5 Trigger Sequence Animesh Manna
2015-04-16 9:25 ` Imre Deak
2015-04-16 9:48 ` Imre Deak
2015-04-17 5:59 ` Animesh Manna
2015-04-17 7:15 ` Imre Deak
2015-04-17 14:16 ` [PATCH v5 2/2] " Animesh Manna
2015-04-30 13:18 ` Imre Deak
2015-05-04 9:39 ` Daniel Vetter
2015-04-16 8:52 ` [PATCH v4 3/8] drm/i915/skl: Implement enable/disable for Display C5 state Animesh Manna
2015-04-30 13:21 ` Imre Deak
2015-04-16 8:52 ` [PATCH v4 4/8] drm/i915/skl: Assert the requirements to enter or exit DC5 Animesh Manna
2015-04-30 13:26 ` Imre Deak
2015-04-16 8:52 ` [PATCH v4 5/8] drm/i915/skl: Add DC6 Trigger sequence Animesh Manna
2015-04-30 13:41 ` Imre Deak
2015-05-04 9:44 ` Daniel Vetter
2015-05-04 13:05 ` Daniel Vetter
2015-04-16 8:52 ` [PATCH v4 6/8] Implement enable/disable for Display C6 state Animesh Manna
2015-04-30 13:45 ` Imre Deak
2015-04-16 8:52 ` [PATCH v4 7/8] drm/i915/skl: Assert the requirements to enter or exit DC6 Animesh Manna
2015-04-16 8:52 ` [PATCH v4 8/8] drm/i915/skl: Enable runtime PM Animesh Manna
2015-04-17 1:52 ` shuang.he
2015-04-30 13:47 ` Imre Deak
2015-05-04 13:12 ` [PATCH v4 0/8] Enable DC states for skl Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1429176117.26416.15.camel@intel.com \
--to=imre.deak@intel.com \
--cc=animesh.manna@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.