All of lore.kernel.org
 help / color / mirror / Atom feed
From: Imre Deak <imre.deak@intel.com>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Daniel Vetter <daniel.vetter@intel.com>,
	Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/i915/dp: Remove intel_ prefix from hw signal_levels functions
Date: Thu, 16 Apr 2015 12:41:01 +0300	[thread overview]
Message-ID: <1429177261.26416.24.camel@intel.com> (raw)
In-Reply-To: <1429177104-20888-1-git-send-email-daniel.vetter@ffwll.ch>

On to, 2015-04-16 at 11:38 +0200, Daniel Vetter wrote:
> intel_ is for generic code bxt_ and friends for platform specific
> functions. Remove the intel_ prefix to be consistent with our naming.
> 
> Random OCD bikeshed I've spotted while merging bxt patches.
> 
> Cc: Imre Deak <imre.deak@intel.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>

Reviewed-by: Imre Deak <imre.deak@intel.com>

> ---
>  drivers/gpu/drm/i915/intel_dp.c | 22 +++++++++++-----------
>  1 file changed, 11 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
> index aa13608d27ff..31258772bba3 100644
> --- a/drivers/gpu/drm/i915/intel_dp.c
> +++ b/drivers/gpu/drm/i915/intel_dp.c
> @@ -3317,7 +3317,7 @@ intel_gen4_signal_levels(uint8_t train_set)
>  
>  /* Gen6's DP voltage swing and pre-emphasis control */
>  static uint32_t
> -intel_gen6_edp_signal_levels(uint8_t train_set)
> +gen6_edp_signal_levels(uint8_t train_set)
>  {
>  	int signal_levels = train_set & (DP_TRAIN_VOLTAGE_SWING_MASK |
>  					 DP_TRAIN_PRE_EMPHASIS_MASK);
> @@ -3345,7 +3345,7 @@ intel_gen6_edp_signal_levels(uint8_t train_set)
>  
>  /* Gen7's DP voltage swing and pre-emphasis control */
>  static uint32_t
> -intel_gen7_edp_signal_levels(uint8_t train_set)
> +gen7_edp_signal_levels(uint8_t train_set)
>  {
>  	int signal_levels = train_set & (DP_TRAIN_VOLTAGE_SWING_MASK |
>  					 DP_TRAIN_PRE_EMPHASIS_MASK);
> @@ -3376,7 +3376,7 @@ intel_gen7_edp_signal_levels(uint8_t train_set)
>  
>  /* Gen7.5's (HSW) DP voltage swing and pre-emphasis control */
>  static uint32_t
> -intel_hsw_signal_levels(uint8_t train_set)
> +hsw_signal_levels(uint8_t train_set)
>  {
>  	int signal_levels = train_set & (DP_TRAIN_VOLTAGE_SWING_MASK |
>  					 DP_TRAIN_PRE_EMPHASIS_MASK);
> @@ -3411,7 +3411,7 @@ intel_hsw_signal_levels(uint8_t train_set)
>  	}
>  }
>  
> -static void intel_bxt_signal_levels(struct intel_dp *intel_dp)
> +static void bxt_signal_levels(struct intel_dp *intel_dp)
>  {
>  	struct intel_digital_port *dport = dp_to_dig_port(intel_dp);
>  	enum port port = dport->port;
> @@ -3472,25 +3472,25 @@ intel_dp_set_signal_levels(struct intel_dp *intel_dp, uint32_t *DP)
>  
>  	if (IS_BROXTON(dev)) {
>  		signal_levels = 0;
> -		intel_bxt_signal_levels(intel_dp);
> +		bxt_signal_levels(intel_dp);
>  		mask = 0;
>  	} else if (HAS_DDI(dev)) {
> -		signal_levels = intel_hsw_signal_levels(train_set);
> +		signal_levels = hsw_signal_levels(train_set);
>  		mask = DDI_BUF_EMP_MASK;
>  	} else if (IS_CHERRYVIEW(dev)) {
> -		signal_levels = intel_chv_signal_levels(intel_dp);
> +		signal_levels = chv_signal_levels(intel_dp);
>  		mask = 0;
>  	} else if (IS_VALLEYVIEW(dev)) {
> -		signal_levels = intel_vlv_signal_levels(intel_dp);
> +		signal_levels = vlv_signal_levels(intel_dp);
>  		mask = 0;
>  	} else if (IS_GEN7(dev) && port == PORT_A) {
> -		signal_levels = intel_gen7_edp_signal_levels(train_set);
> +		signal_levels = gen7_edp_signal_levels(train_set);
>  		mask = EDP_LINK_TRAIN_VOL_EMP_MASK_IVB;
>  	} else if (IS_GEN6(dev) && port == PORT_A) {
> -		signal_levels = intel_gen6_edp_signal_levels(train_set);
> +		signal_levels = gen6_edp_signal_levels(train_set);
>  		mask = EDP_LINK_TRAIN_VOL_EMP_MASK_SNB;
>  	} else {
> -		signal_levels = intel_gen4_signal_levels(train_set);
> +		signal_levels = gen4_signal_levels(train_set);
>  		mask = DP_VOLTAGE_MASK | DP_PRE_EMPHASIS_MASK;
>  	}
>  


_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2015-04-16  9:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-16  9:38 [PATCH] drm/i915/dp: Remove intel_ prefix from hw signal_levels functions Daniel Vetter
2015-04-16  9:41 ` Imre Deak [this message]
2015-04-16  9:43 ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1429177261.26416.24.camel@intel.com \
    --to=imre.deak@intel.com \
    --cc=daniel.vetter@ffwll.ch \
    --cc=daniel.vetter@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.