From: riku.voipio@linaro.org
To: linux-kbuild@vger.kernel.org, mmarek@suse.cz,
debian-kernel@lists.debian.org
Cc: Riku Voipio <riku.voipio@linaro.org>
Subject: [PATCH] deb-pkg: v2: move setting debarch for a separate function
Date: Thu, 16 Apr 2015 16:42:46 +0300 [thread overview]
Message-ID: <1429191766-13385-1-git-send-email-riku.voipio@linaro.org> (raw)
In-Reply-To: <552E59D9.7060101@suse.cz>
From: Riku Voipio <riku.voipio@linaro.org>
create_package() function tries to resolve used architecture
for everry package. Split the setting the architecture to a
new function, set_debarch(), called once on startup.
This allows using debarch from other parts of script as
needed.
v2: Follow Michals suggestion on setting variables at
top scope and also setting the fallback $debarch in the
new function
Signed-off-by: Riku Voipio <riku.voipio@linaro.org>
---
scripts/package/builddeb | 18 +++++++++++-------
1 file changed, 11 insertions(+), 7 deletions(-)
diff --git a/scripts/package/builddeb b/scripts/package/builddeb
index a9858a4..d9b7694 100755
--- a/scripts/package/builddeb
+++ b/scripts/package/builddeb
@@ -27,8 +27,13 @@ create_package() {
chown -R root:root "$pdir"
chmod -R go-w "$pdir"
+ # Create the package
+ dpkg-gencontrol $forcearch -Vkernel:debarch="${debarch}" -p$pname -P"$pdir"
+ dpkg --build "$pdir" ..
+}
+
+set_debarch() {
# Attempt to find the correct Debian architecture
- local forcearch="" debarch=""
case "$UTS_MACHINE" in
i386|ia64|alpha)
debarch="$UTS_MACHINE" ;;
@@ -58,6 +63,7 @@ create_package() {
fi
;;
*)
+ debarch=$(dpkg --print-architecture)
echo "" >&2
echo "** ** ** WARNING ** ** **" >&2
echo "" >&2
@@ -70,13 +76,8 @@ create_package() {
if [ -n "$KBUILD_DEBARCH" ] ; then
debarch="$KBUILD_DEBARCH"
fi
- if [ -n "$debarch" ] ; then
- forcearch="-DArchitecture=$debarch"
- fi
+ forcearch="-DArchitecture=$debarch"
- # Create the package
- dpkg-gencontrol $forcearch -Vkernel:debarch="${debarch:-$(dpkg --print-architecture)}" -p$pname -P"$pdir"
- dpkg --build "$pdir" ..
}
# Some variables and settings used throughout the script
@@ -99,6 +100,9 @@ kernel_headers_packagename=linux-headers-$version
libc_headers_packagename=linux-libc-dev
dbg_packagename=$packagename-dbg
tools_packagename=linux-tools-$version
+debarch=
+forcearch=
+set_debarch
if [ "$ARCH" = "um" ] ; then
packagename=user-mode-linux-$version
--
2.1.4
next prev parent reply other threads:[~2015-04-16 13:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-10 13:15 [PATCH 1/2] deb-pkg: move setting debarch for a separate function riku.voipio
2015-04-10 13:15 ` [PATCH 2/2] deb-pkg: add source package riku.voipio
2015-04-22 15:50 ` maximilian attems
2015-04-23 9:01 ` Riku Voipio
2015-04-23 10:43 ` maximilian attems
2015-04-15 12:30 ` [PATCH 1/2] deb-pkg: move setting debarch for a separate function Michal Marek
2015-04-16 13:42 ` riku.voipio [this message]
2015-04-22 14:45 ` [PATCH] deb-pkg: v2: " Michal Marek
2015-04-22 15:52 ` maximilian attems
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1429191766-13385-1-git-send-email-riku.voipio@linaro.org \
--to=riku.voipio@linaro.org \
--cc=debian-kernel@lists.debian.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=mmarek@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.