Re: [PATCH 0/2] Re-factoring passthrough/pci.c and adding place-holder code for ARM/PCI

From: Ian Campbell <ian.campbell@citrix.com>
To: Manish Jaggi <mjaggi@caviumnetworks.com>
Cc: "Prasun.kapoor@cavium.com" <Prasun.kapoor@cavium.com>,
	"Kumar, Vijaya" <Vijaya.Kumar@caviumnetworks.com>,
	Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
	Julien Grall <julien.grall@linaro.org>,
	xen Devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH 0/2] Re-factoring passthrough/pci.c and adding place-holder code for ARM/PCI
Date: Thu, 16 Apr 2015 16:27:18 +0100	[thread overview]
Message-ID: <1429198038.25195.162.camel@citrix.com> (raw)
In-Reply-To: <552B724A.8080400@caviumnetworks.com>

On Mon, 2015-04-13 at 13:07 +0530, Manish Jaggi wrote:

Please use git send-email (or an equivalent manual procedure) such that
the two patches appear in the same threads and not as two more
independent threads.

On this occasion I found I only had 0/2 and 2/2 filed away in my queue,
so I had to waste time going to locate the other bit, this makes me
grumpy right before I'm about to look at your code.

Secondly since this touches more than just arm specific code you need to
CC all of the relevant maintainers. Using ./script/get_maintainer.pl can
help with this.

> Xen currently does not have PCI support for ARM builds. This patch set
> makes the code compilable for ARM PCI and adds places-holder code
> which would be replaced with PCI pass-through support patch series.
> 
> Re-factor MSI Handling
> -------------
> There is a some x86 specific code which is found in common code:
> xen/drivers/passthrough/pci.c which needs to be re factored.
> 
> MSI/X are configured and handled by dom0 or domU code on ARM64 and is not
> required to be part of common code. However there are functions which are
> used as part of common code and calls to these functions cannot be easily
> re factored like pci_cleanup_msi.
> 
> xen/drivers/passthrough/<arch>/pci.c files handle these functions.
> 
> Add ARM PCI Support
> ---------------
> a) Place holder functions are added for pci_conf_read/write calls.
> b) Macros dev_is_pci, pci_to_dev are implemented in
> drivers/passthrough/pci/arm code
> 
> Manish Jaggi (2):
>    xen/x86: Patch re-factors MSI/X config code from
>      drivers/passthrough/pci.c to x86 specific
>    xen/arm: Make HAS_PCI compilable on ARM by adding place-holder code
> 
>   xen/arch/arm/Makefile                |    1 +
>   xen/arch/arm/pci.c                   |   60 ++++++++++++++++++
>   xen/drivers/passthrough/arm/Makefile |    1 +
>   xen/drivers/passthrough/arm/pci.c    |   88 ++++++++++++++++++++++++++
>   xen/drivers/passthrough/arm/smmu.c   |    1 -
>   xen/drivers/passthrough/pci.c        |  111 +++-----------------------------
>   xen/drivers/passthrough/x86/Makefile |    1 +
>   xen/drivers/passthrough/x86/pci.c    |  115 ++++++++++++++++++++++++++++++++++
>   xen/include/asm-arm/device.h         |   33 +++++++---
>   xen/include/asm-arm/domain.h         |    3 +
>   xen/include/asm-arm/pci.h            |    7 ++-
>   xen/include/asm-x86/msi.h            |    1 -
>   xen/include/xen/pci.h                |   20 +++++-
>   13 files changed, 323 insertions(+), 119 deletions(-)
>   create mode 100644 xen/arch/arm/pci.c
>   create mode 100644 xen/drivers/passthrough/arm/pci.c
>   create mode 100644 xen/drivers/passthrough/x86/pci.c
> 