All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Campbell <ian.campbell@citrix.com>
To: Manish Jaggi <mjaggi@caviumnetworks.com>
Cc: "Prasun.kapoor@cavium.com" <Prasun.kapoor@cavium.com>,
	"Kumar, Vijaya" <Vijaya.Kumar@caviumnetworks.com>,
	Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
	Julien Grall <julien.grall@linaro.org>,
	Xen Devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH 2/2] xen/arm: Make HAS_PCI compilable on ARM by adding place-holder code
Date: Thu, 16 Apr 2015 16:36:12 +0100	[thread overview]
Message-ID: <1429198572.25195.166.camel@citrix.com> (raw)
In-Reply-To: <552B74B3.6000702@caviumnetworks.com>

On Mon, 2015-04-13 at 13:18 +0530, Manish Jaggi wrote:
> uint8_t pci_conf_read8(
> +    uint32_t seg, uint32_t bus, uint32_t dev, uint32_t func,
> +    uint32_t reg)

Shouldn't this (and the other functions) match the prototype in
xen/pci.h, which is:
uint8_t pci_conf_read8(
    unsigned int seg, unsigned int bus, unsigned int dev, unsigned int func,
    unsigned int reg);
?

We generally try and use precisely sized types in the ARM code, but
where we interact with generic/common interfaces we should either follow
what they do or make an argument (via a preparatory patch) for changing
them.

Ian.

      parent reply	other threads:[~2015-04-16 15:36 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-13  7:48 [PATCH 2/2] xen/arm: Make HAS_PCI compilable on ARM by adding place-holder code Manish Jaggi
2015-04-13 10:14 ` Stefano Stabellini
2015-04-13 10:31   ` Manish Jaggi
2015-04-13 10:42 ` Julien Grall
2015-04-14  1:28   ` Jaggi, Manish
2015-04-14  9:28     ` Stefano Stabellini
2015-04-14 10:33       ` Julien Grall
2015-04-14 13:27         ` Julien Grall
2015-04-16 15:36 ` Ian Campbell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1429198572.25195.166.camel@citrix.com \
    --to=ian.campbell@citrix.com \
    --cc=Prasun.kapoor@cavium.com \
    --cc=Vijaya.Kumar@caviumnetworks.com \
    --cc=julien.grall@linaro.org \
    --cc=mjaggi@caviumnetworks.com \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.