From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59869) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yj1CI-0006Z2-9E for qemu-devel@nongnu.org; Fri, 17 Apr 2015 04:00:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yj1CF-0001Q7-EW for qemu-devel@nongnu.org; Fri, 17 Apr 2015 04:00:22 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41132) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yj1CF-0001Pw-70 for qemu-devel@nongnu.org; Fri, 17 Apr 2015 04:00:19 -0400 From: Fam Zheng Date: Fri, 17 Apr 2015 15:59:22 +0800 Message-Id: <1429257573-7359-8-git-send-email-famz@redhat.com> In-Reply-To: <1429257573-7359-1-git-send-email-famz@redhat.com> References: <1429257573-7359-1-git-send-email-famz@redhat.com> Subject: [Qemu-devel] [PATCH 07/18] virtio: Return error from virtqueue_avail_bytes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Kevin Wolf , "Michael S. Tsirkin" , "Aneesh Kumar K.V" , Stefan Hajnoczi , Amit Shah , Paolo Bonzini The only caller is virtio-net, which now passes in error_abort. Signed-off-by: Fam Zheng --- hw/net/virtio-net.c | 4 ++-- hw/virtio/virtio.c | 9 +++++++-- include/hw/virtio/virtio.h | 2 +- 3 files changed, 10 insertions(+), 5 deletions(-) diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c index bbcb51f..5529b6f 100644 --- a/hw/net/virtio-net.c +++ b/hw/net/virtio-net.c @@ -877,7 +877,7 @@ static int virtio_net_has_buffers(VirtIONetQueue *q, int bufsize) VirtIONet *n = q->n; if (virtio_queue_empty(q->rx_vq) || (n->mergeable_rx_bufs && - !virtqueue_avail_bytes(q->rx_vq, bufsize, 0))) { + !virtqueue_avail_bytes(q->rx_vq, bufsize, 0, &error_abort))) { virtio_queue_set_notification(q->rx_vq, 1); /* To avoid a race condition where the guest has made some buffers @@ -886,7 +886,7 @@ static int virtio_net_has_buffers(VirtIONetQueue *q, int bufsize) */ if (virtio_queue_empty(q->rx_vq) || (n->mergeable_rx_bufs && - !virtqueue_avail_bytes(q->rx_vq, bufsize, 0))) { + !virtqueue_avail_bytes(q->rx_vq, bufsize, 0, &error_abort))) { return 0; } } diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c index e6f9f6b..7c5ca07 100644 --- a/hw/virtio/virtio.c +++ b/hw/virtio/virtio.c @@ -443,12 +443,17 @@ done: } int virtqueue_avail_bytes(VirtQueue *vq, unsigned int in_bytes, - unsigned int out_bytes) + unsigned int out_bytes, Error **errp) { + Error *local_err = NULL; unsigned int in_total, out_total; virtqueue_get_avail_bytes(vq, &in_total, &out_total, in_bytes, out_bytes, - &error_abort); + &local_err); + if (local_err) { + error_propagate(errp, local_err); + return -EINVAL; + } return in_bytes <= in_total && out_bytes <= out_total; } diff --git a/include/hw/virtio/virtio.h b/include/hw/virtio/virtio.h index c478f48..34fb62c 100644 --- a/include/hw/virtio/virtio.h +++ b/include/hw/virtio/virtio.h @@ -144,7 +144,7 @@ void virtqueue_map_sg(struct iovec *sg, hwaddr *addr, Error **errp); int virtqueue_pop(VirtQueue *vq, VirtQueueElement *elem, Error **errp); int virtqueue_avail_bytes(VirtQueue *vq, unsigned int in_bytes, - unsigned int out_bytes); + unsigned int out_bytes, Error **errp); void virtqueue_get_avail_bytes(VirtQueue *vq, unsigned int *in_bytes, unsigned int *out_bytes, unsigned max_in_bytes, unsigned max_out_bytes, -- 1.9.3