From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752942AbbDSUeo (ORCPT ); Sun, 19 Apr 2015 16:34:44 -0400 Received: from smtprelay0183.hostedemail.com ([216.40.44.183]:53552 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752343AbbDSUel (ORCPT ); Sun, 19 Apr 2015 16:34:41 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::,RULES_HIT:41:355:379:541:599:973:982:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1543:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:2914:3138:3139:3140:3141:3142:3354:3622:3865:3866:3867:3868:3870:4321:5007:6261:7875:7903:9592:10004:10400:10848:11026:11232:11658:11914:12043:12296:12438:12517:12519:12555:12740:13071:13161:13229:14093:14097:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: town30_62b7cd58bef23 X-Filterd-Recvd-Size: 3994 Message-ID: <1429475676.2947.43.camel@perches.com> Subject: Re: [PATCH] Staging: dgnc: fixed code style issue From: Joe Perches To: Yorick Rommers Cc: lidza.louina@gmail.com, markh@compro.net, gregkh@linuxfoundation.org, driverdev-devel@linuxdriverproject.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Date: Sun, 19 Apr 2015 13:34:36 -0700 In-Reply-To: References: Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.10-0ubuntu1~14.10.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2015-04-19 at 21:18 +0200, Yorick Rommers wrote: > A patch for a line being too long (>80) in dgnc_mgmt.c, > fixed by making a temporary value for dgnc_Board[brd], and removing > an unnecessary typecast. Hello Yorick. The patch subject isn't very descriptive. A better subject might be something like: "staging: dgnc: Use a temporary for repeated dereferences" > diff --git a/drivers/staging/dgnc/dgnc_mgmt.c b/drivers/staging/dgnc/dgnc_mgmt.c [] > @@ -143,12 +143,14 @@ long dgnc_mgmt_ioctl(struct file *file, unsigned int cmd, unsigned long arg) > di.info_bdnum = brd; > > spin_lock_irqsave(&dgnc_Board[brd]->bd_lock, flags); > + struct dgnc_board *bd = dgnc_Board[brd]; Linux style doesn't declare variables in the middle of a function, Variables are only declared after an open brace. > > di.info_bdtype = dgnc_Board[brd]->dpatype; > di.info_bdstate = dgnc_Board[brd]->dpastatus; Please change all the references of dgnc_Board[brd]-> to bd-> in this function instead of just the long line ones. > di.info_ioport = 0; > di.info_physaddr = (ulong) dgnc_Board[brd]->membase; > - di.info_physsize = (ulong) dgnc_Board[brd]->membase - dgnc_Board[brd]->membase_end; > + di.info_physsize = bd->membase - bd->membase_end; > + > if (dgnc_Board[brd]->state != BOARD_FAILED) > di.info_nports = dgnc_Board[brd]->nasync; > else Something like: drivers/staging/dgnc/dgnc_mgmt.c | 20 +++++++++++--------- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_mgmt.c b/drivers/staging/dgnc/dgnc_mgmt.c index b13318a..215f37b 100644 --- a/drivers/staging/dgnc/dgnc_mgmt.c +++ b/drivers/staging/dgnc/dgnc_mgmt.c @@ -129,8 +129,8 @@ long dgnc_mgmt_ioctl(struct file *file, unsigned int cmd, unsigned long arg) case DIGI_GETBD: { int brd; - struct digi_info di; + struct dgnc_board *bd; if (copy_from_user(&brd, uarg, sizeof(int))) return -EFAULT; @@ -142,19 +142,21 @@ long dgnc_mgmt_ioctl(struct file *file, unsigned int cmd, unsigned long arg) di.info_bdnum = brd; - spin_lock_irqsave(&dgnc_Board[brd]->bd_lock, flags); + bd = dgnc_Board[brd]; + + spin_lock_irqsave(&bd->bd_lock, flags); - di.info_bdtype = dgnc_Board[brd]->dpatype; - di.info_bdstate = dgnc_Board[brd]->dpastatus; + di.info_bdtype = bd->dpatype; + di.info_bdstate = bd->dpastatus; di.info_ioport = 0; - di.info_physaddr = (ulong) dgnc_Board[brd]->membase; - di.info_physsize = (ulong) dgnc_Board[brd]->membase - dgnc_Board[brd]->membase_end; - if (dgnc_Board[brd]->state != BOARD_FAILED) - di.info_nports = dgnc_Board[brd]->nasync; + di.info_physaddr = bd->membase; + di.info_physsize = bd->membase - bd->membase_end; + if (bd->state != BOARD_FAILED) + di.info_nports = bd->nasync; else di.info_nports = 0; - spin_unlock_irqrestore(&dgnc_Board[brd]->bd_lock, flags); + spin_unlock_irqrestore(&bd->bd_lock, flags); if (copy_to_user(uarg, &di, sizeof(di))) return -EFAULT;