From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH] libxl: initialize vfb defbools in
 libxlMakeVfb
Date: Mon, 20 Apr 2015 09:39:03 +0100
Message-ID: <1429519143.25195.363.camel@citrix.com>
References: <1429291171-23640-1-git-send-email-olaf@aepfle.de>
	<553161CA.2090906@suse.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <553161CA.2090906@suse.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jim Fehlig <jfehlig@suse.com>
Cc: libvir-list@redhat.com, Olaf Hering <olaf@aepfle.de>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On Fri, 2015-04-17 at 13:40 -0600, Jim Fehlig wrote:
> On 04/17/2015 11:19 AM, Olaf Hering wrote:
> > If the domU configu has sdl enabled libvirtd crashes:
> > libvirtd[5158]: libvirtd: libxl.c:343: libxl_defbool_val: Assertion `!libxl_defbool_is_default(db)' failed.
> 
> The assertion seems harsh considering the offense...

libxl should be setting a default for this value if the application
hasn't, by calling libxl__device_vfb_setdefault at some correct point.

Not to say the application shouldn't also set it if it has a different
default preference, but there is a libxl bug here somewhere too.

Ian.