All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Bolle <pebolle@tiscali.nl>
To: "pi-cheng.chen" <pi-cheng.chen@linaro.org>
Cc: Viresh Kumar <viresh.kumar@linaro.org>,
	Mike Turquette <mturquette@linaro.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	"Joe.C" <yingjoe.chen@mediatek.com>,
	Eddie Huang <eddie.huang@mediatek.com>,
	Howard Chen <ibanezchen@gmail.com>,
	fan.chen@mediatek.com, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
	linaro-kernel@lists.linaro.org,
	linux-mediatek@lists.infradead.org
Subject: Re: [PATCH 1/2] cpufreq: mediatek: Add MT8173 cpufreq driver
Date: Mon, 20 Apr 2015 20:28:37 +0200	[thread overview]
Message-ID: <1429554517.14597.38.camel@x220> (raw)
In-Reply-To: <1429522047-16675-2-git-send-email-pi-cheng.chen@linaro.org>

On Mon, 2015-04-20 at 17:27 +0800, pi-cheng.chen wrote:
> --- a/drivers/cpufreq/Kconfig.arm
> +++ b/drivers/cpufreq/Kconfig.arm
 
> +config ARM_MT8173_CPUFREQ
> +	bool "Mediatek MT8173 CPUFreq support"
> +	depends on ARCH_MEDIATEK && REGULATOR
> +	help
> +	  This adds the CPUFreq driver support for Mediatek MT8173 SoC.

> --- a/drivers/cpufreq/Makefile
> +++ b/drivers/cpufreq/Makefile

> +obj-$(CONFIG_ARM_MT8173_CPUFREQ)	+= mt8173-cpufreq.o

ARM_MT8173_CPUFREQ is a bool symbol, so mt8173-cpufreq.o will never be
part of a module.

(If that's incorrect you can stop reading here.)

> --- /dev/null
> +++ b/drivers/cpufreq/mt8173-cpufreq.c

> +#include <linux/module.h>

I guess this include is not needed. And, for what it's worth,
    make ARCH=arm CROSS_COMPILE=arm-linux-gnu- drivers/cpufreq/mt8173-cpufreq.o

compiles silently even if it's dropped.

> +module_init(mt8173_cpufreq_driver_init);

According to include/linux/init.h, for built-in only code, this is
equivalent to device_initcall([...]). And two runs of
    make ARCH=arm CROSS_COMPILE=arm-linux-gnu- drivers/cpufreq/mt8173-cpufreq.i

confirm that.

Thanks,


Paul Bolle


WARNING: multiple messages have this Message-ID (diff)
From: pebolle@tiscali.nl (Paul Bolle)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] cpufreq: mediatek: Add MT8173 cpufreq driver
Date: Mon, 20 Apr 2015 20:28:37 +0200	[thread overview]
Message-ID: <1429554517.14597.38.camel@x220> (raw)
In-Reply-To: <1429522047-16675-2-git-send-email-pi-cheng.chen@linaro.org>

On Mon, 2015-04-20 at 17:27 +0800, pi-cheng.chen wrote:
> --- a/drivers/cpufreq/Kconfig.arm
> +++ b/drivers/cpufreq/Kconfig.arm
 
> +config ARM_MT8173_CPUFREQ
> +	bool "Mediatek MT8173 CPUFreq support"
> +	depends on ARCH_MEDIATEK && REGULATOR
> +	help
> +	  This adds the CPUFreq driver support for Mediatek MT8173 SoC.

> --- a/drivers/cpufreq/Makefile
> +++ b/drivers/cpufreq/Makefile

> +obj-$(CONFIG_ARM_MT8173_CPUFREQ)	+= mt8173-cpufreq.o

ARM_MT8173_CPUFREQ is a bool symbol, so mt8173-cpufreq.o will never be
part of a module.

(If that's incorrect you can stop reading here.)

> --- /dev/null
> +++ b/drivers/cpufreq/mt8173-cpufreq.c

> +#include <linux/module.h>

I guess this include is not needed. And, for what it's worth,
    make ARCH=arm CROSS_COMPILE=arm-linux-gnu- drivers/cpufreq/mt8173-cpufreq.o

compiles silently even if it's dropped.

> +module_init(mt8173_cpufreq_driver_init);

According to include/linux/init.h, for built-in only code, this is
equivalent to device_initcall([...]). And two runs of
    make ARCH=arm CROSS_COMPILE=arm-linux-gnu- drivers/cpufreq/mt8173-cpufreq.i

confirm that.

Thanks,


Paul Bolle

  parent reply	other threads:[~2015-04-20 18:28 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-20  9:27 [PATCH v3 0/2] cpufreq: add cpufreq driver for Mediatek MT8173 SoC pi-cheng.chen
2015-04-20  9:27 ` pi-cheng.chen
2015-04-20  9:27 ` [PATCH 1/2] cpufreq: mediatek: Add MT8173 cpufreq driver pi-cheng.chen
2015-04-20  9:27   ` pi-cheng.chen
2015-04-20  9:27   ` pi-cheng.chen
2015-04-20 14:17   ` Josh Cartwright
2015-04-20 14:17     ` Josh Cartwright
2015-04-20 14:17     ` Josh Cartwright
2015-04-20 18:31     ` Paul Bolle
2015-04-20 18:31       ` Paul Bolle
2015-04-22  3:11     ` Pi-Cheng Chen
2015-04-22  3:11       ` Pi-Cheng Chen
2015-04-22  3:11       ` Pi-Cheng Chen
2015-04-22 14:33       ` Josh Cartwright
2015-04-22 14:33         ` Josh Cartwright
2015-04-22 14:33         ` Josh Cartwright
2015-04-20 18:28   ` Paul Bolle [this message]
2015-04-20 18:28     ` Paul Bolle
2015-04-22  3:14     ` Pi-Cheng Chen
2015-04-22  3:14       ` Pi-Cheng Chen
2015-04-22  3:14       ` Pi-Cheng Chen
2015-04-23 12:01   ` Sascha Hauer
2015-04-23 12:01     ` Sascha Hauer
2015-04-24  6:46     ` Pi-Cheng Chen
2015-04-24  6:46       ` Pi-Cheng Chen
2015-04-24  6:46       ` Pi-Cheng Chen
2015-04-24 12:55       ` Sascha Hauer
2015-04-24 12:55         ` Sascha Hauer
2015-04-24 12:55         ` Sascha Hauer
2015-05-07  9:42         ` Pi-Cheng Chen
2015-05-07  9:42           ` Pi-Cheng Chen
2015-05-07  9:42           ` Pi-Cheng Chen
2015-04-23 12:56   ` Mark Rutland
2015-04-23 12:56     ` Mark Rutland
2015-04-23 12:56     ` Mark Rutland
2015-04-24  6:50     ` Pi-Cheng Chen
2015-04-24  6:50       ` Pi-Cheng Chen
2015-04-24  6:50       ` Pi-Cheng Chen
2015-04-29  6:06       ` Viresh Kumar
2015-04-29  6:06         ` Viresh Kumar
2015-04-29  6:06         ` Viresh Kumar
2015-04-30  7:42   ` Sascha Hauer
2015-04-30  7:42     ` Sascha Hauer
2015-05-07  9:40     ` Pi-Cheng Chen
2015-05-07  9:40       ` Pi-Cheng Chen
2015-05-07  9:40       ` Pi-Cheng Chen
2015-04-20  9:27 ` [PATCH 2/2] ARM64: mt8173: dts Add MT8173 cpufreq driver support pi-cheng.chen
2015-04-20  9:27   ` pi-cheng.chen
2015-04-23 12:53   ` Mark Rutland
2015-04-23 12:53     ` Mark Rutland
2015-04-23 12:53     ` Mark Rutland
2015-04-24  7:09     ` Pi-Cheng Chen
2015-04-24  7:09       ` Pi-Cheng Chen
2015-04-24  7:09       ` Pi-Cheng Chen
2015-05-18 13:29       ` Pi-Cheng Chen
2015-05-18 13:29         ` Pi-Cheng Chen
2015-05-18 13:29         ` Pi-Cheng Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1429554517.14597.38.camel@x220 \
    --to=pebolle@tiscali.nl \
    --cc=devicetree@vger.kernel.org \
    --cc=eddie.huang@mediatek.com \
    --cc=fan.chen@mediatek.com \
    --cc=ibanezchen@gmail.com \
    --cc=linaro-kernel@lists.linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=matthias.bgg@gmail.com \
    --cc=mturquette@linaro.org \
    --cc=pi-cheng.chen@linaro.org \
    --cc=viresh.kumar@linaro.org \
    --cc=yingjoe.chen@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.