From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH v5 11/13] tools/libxl: add command to show
 CMT hardware info
Date: Tue, 21 Apr 2015 14:57:56 +0100
Message-ID: <1429624676.4743.99.camel@citrix.com>
References: <1429281230-4352-1-git-send-email-chao.p.peng@linux.intel.com>
	<1429281230-4352-12-git-send-email-chao.p.peng@linux.intel.com>
	<1429576674.18926.3.camel@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1429576674.18926.3.camel@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Dario Faggioli <dario.faggioli@citrix.com>
Cc: wei.liu2@citrix.com, keir@xen.org, stefano.stabellini@eu.citrix.com, andrew.cooper3@citrix.com, Ian.Jackson@eu.citrix.com, xen-devel@lists.xen.org, will.auld@intel.com, JBeulich@suse.com, Chao Peng <chao.p.peng@linux.intel.com>, dgdegra@tycho.nsa.gov
List-Id: xen-devel@lists.xenproject.org

On Tue, 2015-04-21 at 02:37 +0200, Dario Faggioli wrote:
> On Fri, 2015-04-17 at 22:33 +0800, Chao Peng wrote:
> > Add dedicated one to show hardware information.
> > 
> > [root@vmm-psr]xl psr-cmt-hwinfo
> > Cache Monitoring Technology (CMT):
> > Enabled         : 1
> > Total RMID      : 63
> > Supported monitor types:
> > cache-occupancy
> > total-mem-bandwidth
> > local-mem-bandwidth
> > 
> Nice.
> 
> > Signed-off-by: Chao Peng <chao.p.peng@linux.intel.com>
> 
> > --- a/tools/libxl/xl_cmdimpl.c
> > +++ b/tools/libxl/xl_cmdimpl.c
> > @@ -8014,6 +8014,36 @@ out:
> >  }
> >  
> >  #ifdef LIBXL_HAVE_PSR_CMT
> > +static int psr_cmt_hwinfo(void)
> > +{
> > +    int rc;
> > +    int enabled;
> > +    uint32_t total_rmid;
> > +
> >
> I think you should still have something like:
> 
>     SWITCH_FOREACH_OPT(opt, "", NULL, "psr-cmt-hwinfo", 0) {
>         /* No options */
>     }
> 
> Or `xl psr-cmt-hwinfo -h' wouldn't work, would it?

Yes, that is neded.

> With that done:
> 
>  Reviewed-by: Dario Faggioli <dario.faggioli@citrix.com>

Likewise:
Acked-by: Ian Campbell <ian.campbell@citrix.com>