From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48837)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1YkZuZ-0003zd-RV
	for qemu-devel@nongnu.org; Tue, 21 Apr 2015 11:16:37 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1YkZuU-0004gS-3D
	for qemu-devel@nongnu.org; Tue, 21 Apr 2015 11:16:31 -0400
Received: from mx1.redhat.com ([209.132.183.28]:33437)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1YkZuT-0004gM-Rt
	for qemu-devel@nongnu.org; Tue, 21 Apr 2015 11:16:26 -0400
Received: from int-mx14.intmail.prod.int.phx2.redhat.com
	(int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t3LFGPsc031307
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256
	verify=FAIL)
	for <qemu-devel@nongnu.org>; Tue, 21 Apr 2015 11:16:25 -0400
Message-ID: <1429629382.21164.33.camel@nilsson.home.kraxel.org>
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Tue, 21 Apr 2015 17:16:22 +0200
In-Reply-To: <553667E6.6010704@redhat.com>
References: <1429521560-2743-1-git-send-email-kraxel@redhat.com>
	<1429521560-2743-5-git-send-email-kraxel@redhat.com>
	<55365C33.2090101@redhat.com>
	<1429628650.21164.24.camel@nilsson.home.kraxel.org>
	<553667E6.6010704@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 5/6] [wip] tseg, part1, not (yet) tested
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Laszlo Ersek <lersek@redhat.com>, qemu-devel@nongnu.org, mst@redhat.com

On Di, 2015-04-21 at 17:08 +0200, Paolo Bonzini wrote:
> 
> On 21/04/2015 17:04, Gerd Hoffmann wrote:
> > Hmm.  I think if we merge all the smm / smram / tseg patches in one go
> > this should work.  Without patches reading the ESMRAMC register returns
> > zero.  With the patches the three cache-disable bits are hardcoded to
> > '1'.  This should work for detecting tseg support.
> > 
> > You also have to test for smm support.  The current protocol for this is
> > that seabios checks whenever smm is already initialized (see
> > *_apmc_smm_setup() in seabios/src/fw/smm.c) and if so it skips smm
> > initialization.  Right now qemu sets the bit on reset when running on
> > kvm, so seabios doesn't try to use smm.  On tcg the bit is clear after
> > reset and seabios actually uses smm mode.
> 
> BTW, I plan to add "-machine smm=yes/no/auto".
> 
> Gerd, are you going to implement SMI_EN locking as well?

Sure, can do that while being at it.

cheers,
  Gerd