From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933451AbbDVHTa (ORCPT ); Wed, 22 Apr 2015 03:19:30 -0400 Received: from mail-pa0-f52.google.com ([209.85.220.52]:35928 "EHLO mail-pa0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932279AbbDVHT1 (ORCPT ); Wed, 22 Apr 2015 03:19:27 -0400 From: Namhyung Kim To: Arnaldo Carvalho de Melo Cc: Ingo Molnar , Peter Zijlstra , Jiri Olsa , LKML , David Ahern Subject: [PATCHSET 00/10] perf tools: Assorted cleanup for TUI (v3) Date: Wed, 22 Apr 2015 16:18:11 +0900 Message-Id: <1429687101-4360-1-git-send-email-namhyung@kernel.org> X-Mailer: git-send-email 2.3.5 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, This patches are to cleanup TUI hists browser code for later work. I moved hist_entry_diff and hist_entry_tui under an union in order to reduce memory footprint of hist entry. Also split out hist browser functions to make it easier to read. * changed in v3) - save necessary info in hist_browser (Arnaldo) - rename to struct popup_action (Arnaldo) - split popup registration and callback (Arnaldo) - move TUI-specific fields out of map_symbol * changes in v2) - add comment on the new union fields (Jiri) - add missing sym->namelen check (Jiri) - fix transient bug in zoom out on LEFT key press (Jiri) It's available on 'perf/tui-cleanup-v3' branch in my tree: git://git.kernel.org/pub/scm/linux/kernel/git/namhyung/linux-perf.git Thanks, Namhyung Namhyung Kim (10): perf tools: Move TUI-specific fields into unnamed union perf tools: Move init_have_children field to the unnamed union perf hists browser: Fix possible memory leak perf hists browser: Save hist_browser_timer pointer in hist_browser perf hists browser: Save pstack in the hist_browser perf hists browser: Save perf_session_env in the hist_browser perf hists browser: Split popup menu actions perf hists browser: Split popup menu actions - part 2 perf hists browser: Simplify zooming code a bit perf tools: Move TUI-specific fields out of map_symbol tools/perf/ui/browsers/hists.c | 603 +++++++++++++++++++++++++---------------- tools/perf/util/callchain.h | 4 + tools/perf/util/hist.c | 2 +- tools/perf/util/pstack.c | 7 + tools/perf/util/pstack.h | 1 + tools/perf/util/sort.h | 22 +- tools/perf/util/symbol.h | 2 - 7 files changed, 399 insertions(+), 242 deletions(-) -- 2.3.5