From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH v3 3/4] sched: credit2: indent code sections to make review of patch 4/4 easier Date: Thu, 23 Apr 2015 17:35:20 +0200 Message-ID: <1429803320.18926.195.camel@citrix.com> References: <1427363314-25430-1-git-send-email-jtweaver@hawaii.edu> <1427363314-25430-4-git-send-email-jtweaver@hawaii.edu> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6446998858289695863==" Return-path: In-Reply-To: <1427363314-25430-4-git-send-email-jtweaver@hawaii.edu> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: "Justin T. Weaver" Cc: george.dunlap@eu.citrix.com, henric@hawaii.edu, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org --===============6446998858289695863== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-puEmUcEveCbRcMici7N2" --=-puEmUcEveCbRcMici7N2 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, 2015-03-25 at 23:48 -1000, Justin T. Weaver wrote: > Functions runq_tickle and choose_cpu both have code sections that get tur= ned > into loops in patch 4 v3, soft affinity. Do the indenting here to make th= e > patch 4 diff section easier to read.=20 > Yeah, I know what you mean, an thanks for trying making our job easier! :-) Still, it's rather uncommon a thing to do (it's probably the first time I see it), and I can't call myself a fan of it. So, I'm not sure what others think, but me, I'd say just drop this patch, and do all the functional and non-functional changes all at once. Hopefully, splitting patch4 the way George suggests will make the result easier to review anyway. Thanks and Regards, Dario --=-puEmUcEveCbRcMici7N2 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEABECAAYFAlU5ETgACgkQk4XaBE3IOsQQTACfU45xBEVfCS/NFgIL7XUfdQPX BWsAnRgFxuvhn6Uoby9wHy3JeHYoaJfZ =YjJx -----END PGP SIGNATURE----- --=-puEmUcEveCbRcMici7N2-- --===============6446998858289695863== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============6446998858289695863==--