From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53267C433DF for ; Fri, 15 May 2020 13:19:36 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0534120709 for ; Fri, 15 May 2020 13:19:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=citrix.com header.i=@citrix.com header.b="WkH+sWMV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0534120709 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=citrix.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jZaFG-0005CK-SK; Fri, 15 May 2020 13:19:22 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jZaFF-0005CF-Dz for xen-devel@lists.xenproject.org; Fri, 15 May 2020 13:19:21 +0000 X-Inumbo-ID: af2ac7d2-96ae-11ea-b07b-bc764e2007e4 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id af2ac7d2-96ae-11ea-b07b-bc764e2007e4; Fri, 15 May 2020 13:19:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1589548760; h=subject:to:cc:references:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=D0J6JzjlekOhk7fZXV/q1awfnttraVTjwuLWUd84rUw=; b=WkH+sWMV935Adf+OHZmETH3HMY/9xnnJ7pfvCHVvCtznDH6AcCCJLXvx Cwgc95XpRJzr32gIBshPDM1o+uwU8lzCvlsxDqCPtSVUjibDTEGvaPY1b HTJJNIAHBn1Ltxx1VyTYsyiUOErz1ZWf2HHRiqMnqQ8+w4clMvY7dkGbE s=; Received-SPF: None (esa2.hc3370-68.iphmx.com: no sender authenticity information available from domain of andrew.cooper3@citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa2.hc3370-68.iphmx.com; envelope-from="Andrew.Cooper3@citrix.com"; x-sender="andrew.cooper3@citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa2.hc3370-68.iphmx.com: domain of Andrew.Cooper3@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa2.hc3370-68.iphmx.com; envelope-from="Andrew.Cooper3@citrix.com"; x-sender="Andrew.Cooper3@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ip4:168.245.78.127 ~all" Received-SPF: None (esa2.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa2.hc3370-68.iphmx.com; envelope-from="Andrew.Cooper3@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=andrew.cooper3@citrix.com; spf=Pass smtp.mailfrom=Andrew.Cooper3@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com; dmarc=pass (p=none dis=none) d=citrix.com IronPort-SDR: uv/02h6jRFfjgXt/bPJ8gUbH2iIstUjnwGnu9H7HIRdaop6KwlqNi5WjECa105Bf4Ud2DojuD1 ntrsii1Sc0dlvJkEjEKknph/Zv2hIvO8t+tWV6oGiBFMBOP4pmgd7P1uYoXGZ+kYLIttW+GRg8 +qVTfSTObes2Gm9Hbr7HX7qkrS8KjPOZSGLthJ2CqlZDoYkDFvUmbd0apx0NUt2E99REifxRAC ME/RLzlbseKPOnoOyio3KgNovGKOEMfSotamQTpKGJo4ZYyoxw2IXQrLFZhyx7YMbWWF3cUvwV dFA= X-SBRS: 2.7 X-MesageID: 17650516 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.73,395,1583211600"; d="scan'208";a="17650516" Subject: Re: [PATCH] x86/gen-cpuid: Distinguish default vs max in feature annotations To: Jan Beulich References: <20200508152729.14295-1-andrew.cooper3@citrix.com> From: Andrew Cooper Message-ID: <142f8f43-98fb-506c-0812-e431f2666e5e@citrix.com> Date: Fri, 15 May 2020 14:19:13 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Language: en-GB X-ClientProxiedBy: AMSPEX02CAS01.citrite.net (10.69.22.112) To AMSPEX02CL02.citrite.net (10.69.22.126) X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Xen-devel , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 11/05/2020 08:43, Jan Beulich wrote: > [CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open attachments unless you have verified the sender and know the content is safe. > > On 08.05.2020 17:27, Andrew Cooper wrote: >> @@ -133,9 +134,13 @@ def crunch_numbers(state): >> state.hvm_shadow_def = state.pv_def | state.raw['S'] >> state.hvm_hap_def = state.hvm_shadow_def | state.raw['H'] >> >> + # TODO: Ignore def/max split until the toolstack migration logic is fixed >> state.pv_max = state.pv_def >> state.hvm_shadow_max = state.hvm_shadow_def >> state.hvm_hap_max = state.hvm_hap_def >> + # state.pv_max = state.raw['A'] | state.raw['a'] >> + # state.hvm_shadow_max = state.pv_max | state.raw['S'] | state.raw['s'] >> + # state.hvm_hap_max = state.hvm_shadow_max | state.raw['H'] | state.raw['h'] > While in comment form it doesn't matter yet, for actually enabling > this it would seem to me to be more expressive as > > state.pv_max = state.pv_def | state.raw['a'] > state.hvm_shadow_max = state.hvm_shadow_def | state.pv_max | state.raw['s'] > state.hvm_hap_max = state.hvm_hap_def | state.hvm_shadow_max | state.raw['h'] > > Thoughts? The format/layout of metadata prohibits that from having any kind of difference. Furthermore, expressing it this way doesn't require anyone to look at the *_def derivation to figure out what is going on. I'm going to commit it in this form, but will tidy it up to be properly tabulated in a future patch, to make it easier to read. ~Andrew