Re: [PATCH 3/5] drm/i915: Consider object pinned if any VMA is pinned

[Joonas Lahtinen <joonas.lahtinen@linux.intel.com>]

On pe, 2015-04-24 at 13:29 +0100, Chris Wilson wrote:
> On Fri, Apr 24, 2015 at 03:09:39PM +0300, Joonas Lahtinen wrote:
> > Do not skip special GGTT views when considering whether an object
> > is pinned or not.
> > 
> > Wrong behaviour was introduced in;
> > 
> > commit ec7adb6ee79c8c9fe64d63ad638a31cd62e55515
> > Author: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> > Date:   Mon Mar 16 14:11:13 2015 +0200
> > 
> >     drm/i915: Do not use ggtt_view with (aliasing) PPGTT
> > 
> > Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> > Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
> > Signed-off-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> 
> The function is obsolete. Please review the patches to remove the
> callsite with more explicit vma management.

I do not call it myself at all, and I'm hesitant to change all the code
calling function just because I slipped code to function where it didn't
belong and now needs to be removed :P

I would leave this to the cleanup phase where all VMA related code was
agreed to be moved to its own file. I put it to my TODO list as it's not
related to the partial view series. Just to get this series out ASAP.

Regards, Joonas

> -Chris
> 


_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx