All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Antoine <peter.antoine@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: deepak.s@intel.com, yex.tian@intel.com, david.weinehall@intel.com
Subject: [PATCH] drm/i915: Avoid GPU hang when coming out of P3 or P4
Date: Mon, 27 Apr 2015 15:25:14 +0100	[thread overview]
Message-ID: <1430144714-5101-1-git-send-email-peter.antoine@intel.com> (raw)

This patch fixed a timing issue that causes a GPU hang when a the system
comes out of power saving.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=89600
Signed-off-by: Peter Antoine <peter.antoine@intel.com>
---
 drivers/gpu/drm/i915/i915_drv.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
index e70adfd..648866f 100644
--- a/drivers/gpu/drm/i915/i915_drv.c
+++ b/drivers/gpu/drm/i915/i915_drv.c
@@ -712,6 +712,11 @@ static int i915_drm_resume(struct drm_device *dev)
 	intel_init_pch_refclk(dev);
 	drm_mode_config_reset(dev);
 
+	/* We need working interrupts for modeset enabling ... */
+	intel_runtime_pm_enable_interrupts(dev_priv);
+
+	intel_modeset_init_hw(dev);
+
 	mutex_lock(&dev->struct_mutex);
 	if (i915_gem_init_hw(dev)) {
 		DRM_ERROR("failed to re-initialize GPU, declaring wedged!\n");
@@ -719,11 +724,6 @@ static int i915_drm_resume(struct drm_device *dev)
 	}
 	mutex_unlock(&dev->struct_mutex);
 
-	/* We need working interrupts for modeset enabling ... */
-	intel_runtime_pm_enable_interrupts(dev_priv);
-
-	intel_modeset_init_hw(dev);
-
 	spin_lock_irq(&dev_priv->irq_lock);
 	if (dev_priv->display.hpd_irq_setup)
 		dev_priv->display.hpd_irq_setup(dev);
-- 
1.9.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

             reply	other threads:[~2015-04-27 14:25 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-27 14:25 Peter Antoine [this message]
2015-04-27 14:31 ` [PATCH] drm/i915: Avoid GPU hang when coming out of P3 or P4 Antoine, Peter
2015-04-27 14:33 ` Chris Wilson
2015-04-28  7:18 ` [PATCH v2] drm/i915: Avoid GPU hang when coming out of S3 or S4 Peter Antoine
2015-04-28  7:23   ` Chris Wilson
2015-04-28  8:29     ` S, Deepak
2015-04-28  8:44       ` Chris Wilson
2015-04-28  8:55         ` Deepak S
2015-04-28 14:38           ` Antoine, Peter
2015-04-28 14:46             ` Chris Wilson
2015-04-29 11:07               ` David Weinehall
2015-04-29 11:39                 ` Chris Wilson
2015-05-04 14:55                   ` Daniel Vetter
2015-05-05  7:05                     ` Antoine, Peter
2015-05-05  7:06                       ` Antoine, Peter
2015-05-05  7:43                     ` S, Deepak
2015-04-28  9:28   ` shuang.he
2015-04-28  9:31 ` [PATCH] drm/i915: Avoid GPU hang when coming out of P3 or P4 shuang.he
2015-04-27 14:30 Peter Antoine
2015-04-28  9:30 ` shuang.he

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1430144714-5101-1-git-send-email-peter.antoine@intel.com \
    --to=peter.antoine@intel.com \
    --cc=david.weinehall@intel.com \
    --cc=deepak.s@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=yex.tian@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.