All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Denis V. Lunev" <den@openvz.org>
Cc: Kevin Wolf <kwolf@redhat.com>, "Denis V. Lunev" <den@openvz.org>,
	qemu-devel@nongnu.org, Roman Kagan <rkagan@parallels.com>
Subject: [Qemu-devel] [PATCH 04/27] block/parallels: read up to cluster end in one go
Date: Tue, 28 Apr 2015 10:46:37 +0300	[thread overview]
Message-ID: <1430207220-24458-5-git-send-email-den@openvz.org> (raw)
In-Reply-To: <1430207220-24458-1-git-send-email-den@openvz.org>

From: Roman Kagan <rkagan@parallels.com>

Teach parallels_read() to do reads in coarser granularity than just a
single sector: if requested, read up to the cluster end in one go.

Signed-off-by: Roman Kagan <rkagan@parallels.com>
Reviewed-by: Denis V. Lunev <den@openvz.org>
Signed-off-by: Denis V. Lunev <den@openvz.org>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
CC: Kevin Wolf <kwolf@redhat.com>
---
 block/parallels.c | 18 +++++++++++++-----
 1 file changed, 13 insertions(+), 5 deletions(-)

diff --git a/block/parallels.c b/block/parallels.c
index baefd3e..8770c82 100644
--- a/block/parallels.c
+++ b/block/parallels.c
@@ -159,6 +159,13 @@ static int64_t seek_to_sector(BDRVParallelsState *s, int64_t sector_num)
     return (uint64_t)s->catalog_bitmap[index] * s->off_multiplier + offset;
 }
 
+static int cluster_remainder(BDRVParallelsState *s, int64_t sector_num,
+        int nb_sectors)
+{
+    int ret = s->tracks - sector_num % s->tracks;
+    return MIN(nb_sectors, ret);
+}
+
 static int parallels_read(BlockDriverState *bs, int64_t sector_num,
                     uint8_t *buf, int nb_sectors)
 {
@@ -166,17 +173,18 @@ static int parallels_read(BlockDriverState *bs, int64_t sector_num,
 
     while (nb_sectors > 0) {
         int64_t position = seek_to_sector(s, sector_num);
+        int n = cluster_remainder(s, sector_num, nb_sectors);
         if (position >= 0) {
-            int ret = bdrv_read(bs->file, position, buf, 1);
+            int ret = bdrv_read(bs->file, position, buf, n);
             if (ret < 0) {
                 return ret;
             }
         } else {
-            memset(buf, 0, BDRV_SECTOR_SIZE);
+            memset(buf, 0, n << BDRV_SECTOR_BITS);
         }
-        nb_sectors--;
-        sector_num++;
-        buf += BDRV_SECTOR_SIZE;
+        nb_sectors -= n;
+        sector_num += n;
+        buf += n << BDRV_SECTOR_BITS;
     }
     return 0;
 }
-- 
1.9.1

  parent reply	other threads:[~2015-04-28  7:47 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-28  7:46 [Qemu-devel] [PATCH v4 0/27] write/create for Parallels images with reasonable performance Denis V. Lunev
2015-04-28  7:46 ` [Qemu-devel] [PATCH 01/27] iotests, parallels: quote TEST_IMG in 076 test to be path-safe Denis V. Lunev
2015-04-28  7:46 ` [Qemu-devel] [PATCH 02/27] block/parallels: rename parallels_header to ParallelsHeader Denis V. Lunev
2015-04-28  7:46 ` [Qemu-devel] [PATCH 03/27] block/parallels: switch to bdrv_read Denis V. Lunev
2015-05-18 16:11   ` Stefan Hajnoczi
2015-04-28  7:46 ` Denis V. Lunev [this message]
2015-04-28  7:46 ` [Qemu-devel] [PATCH 05/27] block/parallels: add get_block_status Denis V. Lunev
2015-05-18 16:11   ` Stefan Hajnoczi
2015-04-28  7:46 ` [Qemu-devel] [PATCH 06/27] block/parallels: provide _co_readv routine for parallels format driver Denis V. Lunev
2015-04-28  9:26   ` Roman Kagan
2015-05-18 16:12   ` Stefan Hajnoczi
2015-04-28  7:46 ` [Qemu-devel] [PATCH 07/27] block/parallels: replace magic constants 4, 64 with proper sizeofs Denis V. Lunev
2015-04-28  7:46 ` [Qemu-devel] [PATCH 08/27] block/parallels: mark parallels format driver as zero inited Denis V. Lunev
2015-04-28  9:53   ` Roman Kagan
2015-05-18 16:13   ` Stefan Hajnoczi
2015-04-28  7:46 ` [Qemu-devel] [PATCH 09/27] block/parallels: _co_writev callback for Parallels format Denis V. Lunev
2015-04-28 10:40   ` Roman Kagan
2015-05-18 16:29   ` Stefan Hajnoczi
2015-04-28  7:46 ` [Qemu-devel] [PATCH 10/27] iotests, parallels: test for write into Parallels image Denis V. Lunev
2015-04-28  7:46 ` [Qemu-devel] [PATCH 11/27] block/parallels: support parallels image creation Denis V. Lunev
2015-04-28  7:46 ` [Qemu-devel] [PATCH 12/27] iotests, parallels: test for newly created parallels image via qemu-img Denis V. Lunev
2015-04-28  7:46 ` [Qemu-devel] [PATCH 13/27] parallels: change copyright information in the image header Denis V. Lunev
2015-04-28  7:46 ` [Qemu-devel] [PATCH 14/27] block/parallels: rename catalog_ names to bat_ Denis V. Lunev
2015-04-28  7:46 ` [Qemu-devel] [PATCH 15/27] block/parallels: create bat2sect helper Denis V. Lunev
2015-04-28  7:46 ` [Qemu-devel] [PATCH 16/27] block/parallels: keep BAT bitmap data in little endian in memory Denis V. Lunev
2015-04-28  7:46 ` [Qemu-devel] [PATCH 17/27] block/parallels: read parallels image header and BAT into single buffer Denis V. Lunev
2015-04-28  7:46 ` [Qemu-devel] [PATCH 18/27] block/parallels: move parallels_open/probe to the very end of the file Denis V. Lunev
2015-04-28  7:46 ` [Qemu-devel] [PATCH 19/27] block/parallels: implement parallels_check method of block driver Denis V. Lunev
2015-04-28  7:46 ` [Qemu-devel] [PATCH 20/27] block/parallels: implement incorrect close detection Denis V. Lunev
2015-04-28  7:46 ` [Qemu-devel] [PATCH 21/27] iotests, parallels: check for incorrectly closed image in tests Denis V. Lunev
2015-04-28  7:46 ` [Qemu-devel] [PATCH 22/27] block/parallels: improve image reading performance Denis V. Lunev
2015-04-28  7:46 ` [Qemu-devel] [PATCH 23/27] block/parallels: create bat_entry_off helper Denis V. Lunev
2015-04-28  7:46 ` [Qemu-devel] [PATCH 24/27] block/parallels: delay writing to BAT till bdrv_co_flush_to_os Denis V. Lunev
2015-04-28  7:46 ` [Qemu-devel] [PATCH 25/27] block/parallels: add prealloc-mode and prealloc-size open paramemets Denis V. Lunev
2015-04-28 10:59   ` Roman Kagan
2015-04-29 11:20     ` Roman Kagan
2015-05-18 16:32   ` Stefan Hajnoczi
2015-04-28  7:46 ` [Qemu-devel] [PATCH 26/27] block/parallels: optimize linear image expansion Denis V. Lunev
2015-04-28 11:00   ` Roman Kagan
2015-05-18 16:32   ` Stefan Hajnoczi
2015-04-28  7:47 ` [Qemu-devel] [PATCH 27/27] block/parallels: improve image writing performance further Denis V. Lunev
2015-05-18 16:33   ` Stefan Hajnoczi
2015-05-08 17:39 ` [Qemu-devel] [PATCH v4 0/27] write/create for Parallels images with reasonable performance Denis V. Lunev
2015-05-18  8:24 ` Denis V. Lunev
2015-05-18 16:45 ` Stefan Hajnoczi
2015-05-19  8:26   ` Kevin Wolf
  -- strict thread matches above, loose matches on Subject: below --
2015-03-11 10:27 [Qemu-devel] [PATCH v3 " Denis V. Lunev
2015-03-11 10:27 ` [Qemu-devel] [PATCH 04/27] block/parallels: read up to cluster end in one go Denis V. Lunev
2015-04-22 12:28   ` Stefan Hajnoczi
2015-03-10  8:50 [Qemu-devel] [PATCH v3 0/27] write/create for Parallels images with reasonable performance Denis V. Lunev
2015-03-10  8:50 ` [Qemu-devel] [PATCH 04/27] block/parallels: read up to cluster end in one go Denis V. Lunev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1430207220-24458-5-git-send-email-den@openvz.org \
    --to=den@openvz.org \
    --cc=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rkagan@parallels.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.