All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Campbell <ijc+uboot@hellion.org.uk>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 5/6] sunxi: usb: Do not call phy_probe from hcd code
Date: Sat, 02 May 2015 14:45:11 +0100	[thread overview]
Message-ID: <1430574311.15640.111.camel@hellion.org.uk> (raw)
In-Reply-To: <1430203271-3130-6-git-send-email-hdegoede@redhat.com>

On Tue, 2015-04-28 at 08:41 +0200, Hans de Goede wrote:
> The 2/3 usb-phys on the sunxi SoCs are really a single separate functional
> block, and are modelled as such in devicetree. So once we've moved all the
> sunxi usb code to the driver-model then phy_probe will be called once
> for the entire block from the driver-model enumeration code.
> 
> Move to this now as this also avoids problems with phy_probe being called
> multiple times once we introduce ohci support. This allows us to get rid
> of the sunxi_usb_phy_enabled_count variable as phy_probe now is guaranteed
> to be called only once.
> 
> Since we're effectively rewriting the probe / remove functions, move them
> to the end of the file while we are at it, as that is the most logical place
> for them.
> 
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>

Acked-by: Ian Campbell <ijc@hellion.org.uk>

  reply	other threads:[~2015-05-02 13:45 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-28  6:41 [U-Boot] [PATCH 0/6] sunxi: usb: Turn the usbc code into a usb-phy driver Hans de Goede
2015-04-28  6:41 ` [U-Boot] [PATCH 1/6] sunxi: usb: Move setup of host controller clocks to the host controller drivers Hans de Goede
2015-05-02 13:40   ` Ian Campbell
2015-04-28  6:41 ` [U-Boot] [PATCH 2/6] sunxi: usb: Remove sunxi_usbc_get_io_base function Hans de Goede
2015-05-02 13:42   ` Ian Campbell
2015-04-28  6:41 ` [U-Boot] [PATCH 3/6] sunxi: usb: Rename sunxi_usbc_foo functions to sunxi_usb_phy_bar Hans de Goede
2015-05-02 13:43   ` Ian Campbell
2015-04-28  6:41 ` [U-Boot] [PATCH 4/6] sunxi: usb: Rename the usbc.? files to usb_phy.? Hans de Goede
2015-05-02 13:43   ` Ian Campbell
2015-04-28  6:41 ` [U-Boot] [PATCH 5/6] sunxi: usb: Do not call phy_probe from hcd code Hans de Goede
2015-05-02 13:45   ` Ian Campbell [this message]
2015-04-28  6:41 ` [U-Boot] [PATCH 6/6] sunxi: usb: Protect phy-init and phy-power-on against multiple calls Hans de Goede
2015-05-02 13:45   ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1430574311.15640.111.camel@hellion.org.uk \
    --to=ijc+uboot@hellion.org.uk \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.