From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFE80C33CAA for ; Tue, 21 Jan 2020 15:11:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9E86821569 for ; Tue, 21 Jan 2020 15:11:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="UWmCdb7R" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729180AbgAUPLA (ORCPT ); Tue, 21 Jan 2020 10:11:00 -0500 Received: from lelv0143.ext.ti.com ([198.47.23.248]:47730 "EHLO lelv0143.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728811AbgAUPLA (ORCPT ); Tue, 21 Jan 2020 10:11:00 -0500 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id 00LFAShC030324; Tue, 21 Jan 2020 09:10:28 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1579619428; bh=S787kA/qOm7iZUqlrj6VPWtJgu9lRcjQf++24S66s1w=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=UWmCdb7RHQmwm75sCCwwuCfCh0z/raPWpI/lqRVhn9ngU4oBWPtBcTQuK9WfA34C+ 3TFNTRLTJAjIguoVgYrIXWmTcvMOMnPpXvWfB6/HgCTfsLCrIxG0cjsYBL06nBR+Kc LZct8oeFCjefinQWsYRx5ZYi8nXI1IsjGXydFVHI= Received: from DLEE107.ent.ti.com (dlee107.ent.ti.com [157.170.170.37]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTP id 00LFAS3S022670; Tue, 21 Jan 2020 09:10:28 -0600 Received: from DLEE100.ent.ti.com (157.170.170.30) by DLEE107.ent.ti.com (157.170.170.37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1847.3; Tue, 21 Jan 2020 09:10:28 -0600 Received: from fllv0040.itg.ti.com (10.64.41.20) by DLEE100.ent.ti.com (157.170.170.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1847.3 via Frontend Transport; Tue, 21 Jan 2020 09:10:28 -0600 Received: from [192.168.2.6] (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id 00LFAPhZ085861; Tue, 21 Jan 2020 09:10:25 -0600 Subject: Re: [PATCH 2/2] drm/bridge: Add tc358768 driver To: Andrzej Hajda , , , , , CC: , , , , , , References: <20191217101506.18910-1-peter.ujfalusi@ti.com> <20191217101506.18910-3-peter.ujfalusi@ti.com> <35d664fe-8091-2744-abf2-69828ebf1148@samsung.com> From: Peter Ujfalusi Message-ID: <14306079-500d-09ca-df94-4cf72c43f858@ti.com> Date: Tue, 21 Jan 2020 17:11:05 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <35d664fe-8091-2744-abf2-69828ebf1148@samsung.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 8bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Andrzej, On 16/01/2020 16.35, Andrzej Hajda wrote: > On 17.12.2019 11:15, Peter Ujfalusi wrote: >> Add basic support for the Toshiba TC358768 RGB to DSI bridge. >> Not all the features of the TC358768 is implemented by the initial driver: >> MIPI_DSI_MODE_VIDEO and MIPI_DSI_FMT_RGB888 is only supported and tested. >> >> Only write is implemented for mipi_dsi_host_ops.transfer. >> >> Signed-off-by: Peter Ujfalusi >> --- >> drivers/gpu/drm/bridge/Kconfig | 10 + >> drivers/gpu/drm/bridge/Makefile | 1 + >> drivers/gpu/drm/bridge/tc358768.c | 963 ++++++++++++++++++++++++++++++ >> 3 files changed, 974 insertions(+) >> create mode 100644 drivers/gpu/drm/bridge/tc358768.c >> >> diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig >> index ccc698c44f58..fd65666702e1 100644 >> --- a/drivers/gpu/drm/bridge/Kconfig >> +++ b/drivers/gpu/drm/bridge/Kconfig >> @@ -122,6 +122,16 @@ config DRM_TOSHIBA_TC358767 >> ---help--- >> Toshiba TC358767 eDP bridge chip driver. >> >> +config DRM_TOSHIBA_TC358768 >> + tristate "Toshiba TC358768 MIPI DSI bridge" >> + depends on OF >> + select DRM_KMS_HELPER >> + select REGMAP_I2C >> + select DRM_PANEL >> + select DRM_MIPI_DSI >> + help >> + Toshiba TC358768AXBG/TC358778XBG DSI bridge chip driver. >> + >> config DRM_TI_TFP410 >> tristate "TI TFP410 DVI/HDMI bridge" >> depends on OF >> diff --git a/drivers/gpu/drm/bridge/Makefile b/drivers/gpu/drm/bridge/Makefile >> index a6c7dd7727ea..204696e30572 100644 >> --- a/drivers/gpu/drm/bridge/Makefile >> +++ b/drivers/gpu/drm/bridge/Makefile >> @@ -11,6 +11,7 @@ obj-$(CONFIG_DRM_SII9234) += sii9234.o >> obj-$(CONFIG_DRM_THINE_THC63LVD1024) += thc63lvd1024.o >> obj-$(CONFIG_DRM_TOSHIBA_TC358764) += tc358764.o >> obj-$(CONFIG_DRM_TOSHIBA_TC358767) += tc358767.o >> +obj-$(CONFIG_DRM_TOSHIBA_TC358768) += tc358768.o >> obj-$(CONFIG_DRM_I2C_ADV7511) += adv7511/ >> obj-$(CONFIG_DRM_TI_SN65DSI86) += ti-sn65dsi86.o >> obj-$(CONFIG_DRM_TI_TFP410) += ti-tfp410.o >> diff --git a/drivers/gpu/drm/bridge/tc358768.c b/drivers/gpu/drm/bridge/tc358768.c >> new file mode 100644 >> index 000000000000..63571191b1c4 >> --- /dev/null >> +++ b/drivers/gpu/drm/bridge/tc358768.c >> @@ -0,0 +1,963 @@ >> +// SPDX-License-Identifier: GPL-2.0 >> +/* >> + * Copyright (C) 2018 Texas Instruments Incorporated - http://www.ti.com > > > Just FYI, we have 2020 already, maybe update needed. Oh, how time flies ;) > > >> + * Author: Peter Ujfalusi >> + */ >> + >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include > > > alphabetic order Ok. >> + >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include