Re: [PATCH v3 2/3] pmd: Modified dev_info structure to include default RX/TX configuration

From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
To: Pablo de Lara
	<pablo.de.lara.guarch-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: dev-VfR2kkLFssw@public.gmane.org
Subject: Re: [PATCH v3 2/3] pmd: Modified dev_info structure to include default RX/TX configuration
Date: Fri, 10 Oct 2014 13:14:02 +0200	[thread overview]
Message-ID: <1430683.lO0q5i9e6O@xps13> (raw)
In-Reply-To: <1412156945-6549-3-git-send-email-pablo.de.lara.guarch-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>

Pablo, I have some minor nits on this patchset.
If you agree, I can fix them before applying the patchset.

2014-10-01 10:49, Pablo de Lara:
> +/**
> + *  Default values for port configuration
> + */
> +#define IGB_DEFAULT_RX_FREE_THRESH  32
> +#define IGB_DEFAULT_RX_PTHRESH      8
> +#define IGB_DEFAULT_RX_HTHRESH      8
> +#define IGB_DEFAULT_RX_WTHRESH      0
> +
> +#define IGB_DEFAULT_TX_PTHRESH      32
> +#define IGB_DEFAULT_TX_HTHRESH      0
> +#define IGB_DEFAULT_TX_WTHRESH      0

Comments in .c files are not for doxygen. So /** should be replaced by /*

>  static int eth_igb_get_5tuple_filter(struct rte_eth_dev *dev,
>  			uint16_t index,
>  			struct rte_5tuple_filter *filter, uint16_t *rx_queue);
> -
>  /*
>   * Define VF Stats MACRO for Non "cleared on read" register
>   */

This blank line shouldn't be removed. Probably a typo?

-- 
Thomas