From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752056AbbEDHFV (ORCPT ); Mon, 4 May 2015 03:05:21 -0400 Received: from smtprelay0010.hostedemail.com ([216.40.44.10]:34584 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750975AbbEDHFM (ORCPT ); Mon, 4 May 2015 03:05:12 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::::,RULES_HIT:41:355:379:541:599:960:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2194:2199:2393:2553:2559:2562:2828:3138:3139:3140:3141:3142:3353:3622:3865:3867:3868:4250:4321:5007:6261:7875:8957:10004:10400:10848:11026:11232:11473:11658:11914:12043:12296:12438:12517:12519:12740:13069:13161:13229:13311:13357:14096:14097:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: girls15_10030cdea9527 X-Filterd-Recvd-Size: 2465 Message-ID: <1430723109.2818.1.camel@perches.com> Subject: Re: [PATCH 4/4] mtd: sh_flctl: fix wrapped condition alignment From: Joe Perches To: Vinod Koul Cc: Nicholas Mc Guire , David Woodhouse , Brian Norris , Laurent Pinchart , Kuninori Morimoto , Wolfram Sang , Arnd Bergmann , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Date: Mon, 04 May 2015 00:05:09 -0700 In-Reply-To: <20150504052138.GX3521@localhost> References: <1430553430-21396-1-git-send-email-hofrat@osadl.org> <1430553430-21396-4-git-send-email-hofrat@osadl.org> <20150504052138.GX3521@localhost> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.11-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2015-05-04 at 10:51 +0530, Vinod Koul wrote: > On Sat, May 02, 2015 at 09:57:10AM +0200, Nicholas Mc Guire wrote: > > CodingStyle fix only - align function parameters to opening (. > > > This doesnt look any better to me... The goto and return statements were overly indented > > diff --git a/drivers/mtd/nand/sh_flctl.c b/drivers/mtd/nand/sh_flctl.c [] > > @@ -428,8 +428,8 @@ static void read_fiforeg(struct sh_flctl *flctl, int rlen, int offset) > > > > /* initiate DMA transfer */ > > if (flctl->chan_fifo0_rx && rlen >= 32 && > > - flctl_dma_fifo0_transfer(flctl, buf, rlen, DMA_DEV_TO_MEM) == 0) > > - goto convert; /* DMA success */ > > + flctl_dma_fifo0_transfer(flctl, buf, rlen, DMA_DEV_TO_MEM) == 0) > > + goto convert; /* DMA success */ > > > > /* do polling transfer */ > > for (i = 0; i < len_4align; i++) { > > @@ -487,8 +487,8 @@ static void write_ec_fiforeg(struct sh_flctl *flctl, int rlen, > > > > /* initiate DMA transfer */ > > if (flctl->chan_fifo0_tx && rlen >= 32 && > > - flctl_dma_fifo0_transfer(flctl, buf, rlen, DMA_MEM_TO_DEV) == 0) > > - return; /* DMA success */ > > + flctl_dma_fifo0_transfer(flctl, buf, rlen, DMA_MEM_TO_DEV) == 0) > > + return; /* DMA success */ From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtprelay0182.hostedemail.com ([216.40.44.182] helo=smtprelay.hostedemail.com) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1YpARb-0004rn-7T for linux-mtd@lists.infradead.org; Mon, 04 May 2015 07:05:35 +0000 Message-ID: <1430723109.2818.1.camel@perches.com> Subject: Re: [PATCH 4/4] mtd: sh_flctl: fix wrapped condition alignment From: Joe Perches To: Vinod Koul Date: Mon, 04 May 2015 00:05:09 -0700 In-Reply-To: <20150504052138.GX3521@localhost> References: <1430553430-21396-1-git-send-email-hofrat@osadl.org> <1430553430-21396-4-git-send-email-hofrat@osadl.org> <20150504052138.GX3521@localhost> Content-Type: text/plain; charset="ISO-8859-1" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Cc: Laurent Pinchart , Arnd Bergmann , Kuninori Morimoto , Wolfram Sang , linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, Nicholas Mc Guire , Brian Norris , David Woodhouse List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Mon, 2015-05-04 at 10:51 +0530, Vinod Koul wrote: > On Sat, May 02, 2015 at 09:57:10AM +0200, Nicholas Mc Guire wrote: > > CodingStyle fix only - align function parameters to opening (. > > > This doesnt look any better to me... The goto and return statements were overly indented > > diff --git a/drivers/mtd/nand/sh_flctl.c b/drivers/mtd/nand/sh_flctl.c [] > > @@ -428,8 +428,8 @@ static void read_fiforeg(struct sh_flctl *flctl, int rlen, int offset) > > > > /* initiate DMA transfer */ > > if (flctl->chan_fifo0_rx && rlen >= 32 && > > - flctl_dma_fifo0_transfer(flctl, buf, rlen, DMA_DEV_TO_MEM) == 0) > > - goto convert; /* DMA success */ > > + flctl_dma_fifo0_transfer(flctl, buf, rlen, DMA_DEV_TO_MEM) == 0) > > + goto convert; /* DMA success */ > > > > /* do polling transfer */ > > for (i = 0; i < len_4align; i++) { > > @@ -487,8 +487,8 @@ static void write_ec_fiforeg(struct sh_flctl *flctl, int rlen, > > > > /* initiate DMA transfer */ > > if (flctl->chan_fifo0_tx && rlen >= 32 && > > - flctl_dma_fifo0_transfer(flctl, buf, rlen, DMA_MEM_TO_DEV) == 0) > > - return; /* DMA success */ > > + flctl_dma_fifo0_transfer(flctl, buf, rlen, DMA_MEM_TO_DEV) == 0) > > + return; /* DMA success */