All of lore.kernel.org
 help / color / mirror / Atom feed
From: Oliver Neukum <oneukum@suse.de>
To: Tina Ruchandani <ruchandani.tina@gmail.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] USB: usbmon: Use 64bit timestamp for mon_bin_hdr
Date: Tue, 05 May 2015 08:25:40 +0200	[thread overview]
Message-ID: <1430807140.12261.7.camel@suse.de> (raw)
In-Reply-To: <20150505062056.GA4746@tinar>

On Tue, 2015-05-05 at 11:50 +0530, Tina Ruchandani wrote:
> struct mon_bin_hdr allows for a 64-bit seconds timestamp. The code 
> currently uses 'struct timeval' to populate the timestamp in mon_bin_hdr, 
> which has a 32-bit seconds field and will overflow in year 2038 and beyond.
> This patch replaces 'struct timeval' with 'struct timespec64' which is 
> y2038 safe.

Hi,

but the timestamp will also overflow. So what is the point?

	Regards
		Oliver



  reply	other threads:[~2015-05-05  6:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-05  6:20 [PATCH] USB: usbmon: Use 64bit timestamp for mon_bin_hdr Tina Ruchandani
2015-05-05  6:25 ` Oliver Neukum [this message]
2015-05-05  6:37 Tina Ruchandani
2015-05-05 14:52 ` Alan Stern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1430807140.12261.7.camel@suse.de \
    --to=oneukum@suse.de \
    --cc=arnd@arndb.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=ruchandani.tina@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.