From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH] libxl: initialize vfb defbools in
 libxlMakeVfb
Date: Tue, 5 May 2015 13:01:20 +0100
Message-ID: <1430827280.2660.65.camel__46454.8439755619$1430827971$gmane$org@citrix.com>
References: <1429291171-23640-1-git-send-email-olaf@aepfle.de>
	<20150417175928.GA2516@aepfle.de> <553165B7.8000204@suse.com>
	<1430487940.15640.32.camel@citrix.com> <55439767.60204@suse.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <55439767.60204@suse.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jim Fehlig <jfehlig@suse.com>
Cc: libvir-list@redhat.com, Olaf Hering <olaf@aepfle.de>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On Fri, 2015-05-01 at 09:10 -0600, Jim Fehlig wrote:
> Ian Campbell wrote:
> > On Fri, 2015-04-17 at 13:57 -0600, Jim Fehlig wrote:
> >   
> >> On 04/17/2015 11:59 AM, Olaf Hering wrote:
> >>     
> >>> On Fri, Apr 17, Olaf Hering wrote:
> >>>
> >>>       
> >>>> If the domU configu has sdl enabled libvirtd crashes:
> >>>> libvirtd[5158]: libvirtd: libxl.c:343: libxl_defbool_val: Assertion `!libxl_defbool_is_default(db)' failed.
> >>>>
> >>>> Initialize the relevant defbool variables in libxl_device_vfb.
> >>>>         
> >>> Fix one crash, find another:
> >>>
> >>> Does libvirt have a representation for this one?
> >>>
> >>>    libxl_defbool_val(vfb.sdl.opengl));
> >>>       
> >> I'm not aware of any way to specify OpenGL in libvirt domXML.
> >>
> >>     
> >>> If not, it should be initialized to false in libxlMakeVfb.
> >>>       
> >> As before, seems like the init function should handle this.
> >>     
> >
> > As before, _not_ the init function, the setdefault within libxl should
> > ensure that this is set to some value _before_ it is used. These changes
> > are just hiding libxl bugs.
> >   
> 
> Yes, I agree.
> 
> > Olaf, please can you use gdb to capture the stack trace so we can fix
> > this (and the other issue) properly in libxl instead of just hacking
> > around it in libvirt (which might also be appropriate for compat with
> > old libxl but shouldn't be done without also fixing libxl IMHO).
> >   
> 
> I was torn on committing Olaf's changes to the libvirt libxl driver, but
> in the end did so for the compatibility you noted.

I just fear that the underlying issue will now not be diagnosed.

Ian.