All of lore.kernel.org
 help / color / mirror / Atom feed
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Linus Walleij <linus.walleij@linaro.org>,
	Alexandre Courbot <gnurou@gmail.com>,
	Arnd Bergmann <arnd@arndb.de>
Cc: linux-gpio@vger.kernel.org,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: [PATCH 01/27] drm/bridge: ptn3460: #include <linux/gpio/consumer.h>, depend on GPIOLIB
Date: Tue,  5 May 2015 18:32:17 +0200	[thread overview]
Message-ID: <1430843563-18615-1-git-send-email-geert@linux-m68k.org> (raw)
In-Reply-To: <1430836404-15513-1-git-send-email-geert@linux-m68k.org>

If GPIOLIB=n and asm-generic/gpio.h is not used:

    drivers/gpu/drm/bridge/ptn3460.c: In function ‘ptn3460_pre_enable’:
    drivers/gpu/drm/bridge/ptn3460.c:135: error: implicit declaration of function ‘gpiod_set_value’
    drivers/gpu/drm/bridge/ptn3460.c: In function ‘ptn3460_probe’:
    drivers/gpu/drm/bridge/ptn3460.c:333: error: implicit declaration of function ‘devm_gpiod_get’
    drivers/gpu/drm/bridge/ptn3460.c:333: warning: assignment makes pointer from integer without a cast
    drivers/gpu/drm/bridge/ptn3460.c:340: error: implicit declaration of function ‘gpiod_direction_output’
    drivers/gpu/drm/bridge/ptn3460.c:346: warning: assignment makes pointer from integer without a cast

Add the missing #include <linux/gpio/consumer.h> to fix this.

As the resulting driver won't work with GPIOLIB=n anyway, make
DRM_PTN3460 depend on GPIOLIB || COMPILE_TEST.

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: David Airlie <airlied@linux.ie>
Cc: dri-devel@lists.freedesktop.org
---
 drivers/gpu/drm/bridge/Kconfig   | 4 ++--
 drivers/gpu/drm/bridge/ptn3460.c | 1 +
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
index acef3223772cb899..6cdcd2ec4848edec 100644
--- a/drivers/gpu/drm/bridge/Kconfig
+++ b/drivers/gpu/drm/bridge/Kconfig
@@ -5,8 +5,8 @@ config DRM_DW_HDMI
 
 config DRM_PTN3460
 	tristate "PTN3460 DP/LVDS bridge"
-	depends on DRM
-	depends on OF
+	depends on DRM && OF
+	depends on GPIOLIB || COMPILE_TEST
 	select DRM_KMS_HELPER
 	select DRM_PANEL
 	---help---
diff --git a/drivers/gpu/drm/bridge/ptn3460.c b/drivers/gpu/drm/bridge/ptn3460.c
index 9d2f053382e1889a..63a09e4079f358ff 100644
--- a/drivers/gpu/drm/bridge/ptn3460.c
+++ b/drivers/gpu/drm/bridge/ptn3460.c
@@ -15,6 +15,7 @@
 
 #include <linux/delay.h>
 #include <linux/gpio.h>
+#include <linux/gpio/consumer.h>
 #include <linux/i2c.h>
 #include <linux/module.h>
 #include <linux/of.h>
-- 
1.9.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Linus Walleij <linus.walleij@linaro.org>,
	Alexandre Courbot <gnurou@gmail.com>,
	Arnd Bergmann <arnd@arndb.de>
Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	David Airlie <airlied@linux.ie>,
	dri-devel@lists.freedesktop.org
Subject: [PATCH 01/27] drm/bridge: ptn3460: #include <linux/gpio/consumer.h>, depend on GPIOLIB
Date: Tue,  5 May 2015 18:32:17 +0200	[thread overview]
Message-ID: <1430843563-18615-1-git-send-email-geert@linux-m68k.org> (raw)
In-Reply-To: <1430836404-15513-1-git-send-email-geert@linux-m68k.org>

If GPIOLIB=n and asm-generic/gpio.h is not used:

    drivers/gpu/drm/bridge/ptn3460.c: In function ‘ptn3460_pre_enable’:
    drivers/gpu/drm/bridge/ptn3460.c:135: error: implicit declaration of function ‘gpiod_set_value’
    drivers/gpu/drm/bridge/ptn3460.c: In function ‘ptn3460_probe’:
    drivers/gpu/drm/bridge/ptn3460.c:333: error: implicit declaration of function ‘devm_gpiod_get’
    drivers/gpu/drm/bridge/ptn3460.c:333: warning: assignment makes pointer from integer without a cast
    drivers/gpu/drm/bridge/ptn3460.c:340: error: implicit declaration of function ‘gpiod_direction_output’
    drivers/gpu/drm/bridge/ptn3460.c:346: warning: assignment makes pointer from integer without a cast

Add the missing #include <linux/gpio/consumer.h> to fix this.

As the resulting driver won't work with GPIOLIB=n anyway, make
DRM_PTN3460 depend on GPIOLIB || COMPILE_TEST.

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: David Airlie <airlied@linux.ie>
Cc: dri-devel@lists.freedesktop.org
---
 drivers/gpu/drm/bridge/Kconfig   | 4 ++--
 drivers/gpu/drm/bridge/ptn3460.c | 1 +
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
index acef3223772cb899..6cdcd2ec4848edec 100644
--- a/drivers/gpu/drm/bridge/Kconfig
+++ b/drivers/gpu/drm/bridge/Kconfig
@@ -5,8 +5,8 @@ config DRM_DW_HDMI
 
 config DRM_PTN3460
 	tristate "PTN3460 DP/LVDS bridge"
-	depends on DRM
-	depends on OF
+	depends on DRM && OF
+	depends on GPIOLIB || COMPILE_TEST
 	select DRM_KMS_HELPER
 	select DRM_PANEL
 	---help---
diff --git a/drivers/gpu/drm/bridge/ptn3460.c b/drivers/gpu/drm/bridge/ptn3460.c
index 9d2f053382e1889a..63a09e4079f358ff 100644
--- a/drivers/gpu/drm/bridge/ptn3460.c
+++ b/drivers/gpu/drm/bridge/ptn3460.c
@@ -15,6 +15,7 @@
 
 #include <linux/delay.h>
 #include <linux/gpio.h>
+#include <linux/gpio/consumer.h>
 #include <linux/i2c.h>
 #include <linux/module.h>
 #include <linux/of.h>
-- 
1.9.1


  reply	other threads:[~2015-05-05 16:32 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-05 14:33 [PATCH 00/27] gpio: Allow compile test of GPIO consumers if !GPIOLIB Geert Uytterhoeven
2015-05-05 16:32 ` Geert Uytterhoeven [this message]
2015-05-05 16:32   ` [PATCH 01/27] drm/bridge: ptn3460: #include <linux/gpio/consumer.h>, depend on GPIOLIB Geert Uytterhoeven
2015-05-05 16:32   ` [PATCH 02/27] drm/bridge: ps8622: " Geert Uytterhoeven
2015-06-05 11:21     ` Thierry Reding
2015-05-05 16:32   ` [PATCH 03/27] tpm: Allow compile test of GPIO consumers if !GPIOLIB Geert Uytterhoeven
2015-05-05 20:57     ` Peter Hüwe
2015-05-05 16:32   ` [PATCH 04/27] extcon: " Geert Uytterhoeven
2015-05-05 16:32     ` Geert Uytterhoeven
2015-05-06  5:38     ` Chanwoo Choi
2015-05-05 16:32   ` [PATCH 05/27] hwmon: " Geert Uytterhoeven
2015-05-05 16:32     ` Geert Uytterhoeven
2015-05-05 19:31     ` Guenter Roeck
2015-05-05 16:32   ` [PATCH 06/27] i2c: " Geert Uytterhoeven
2015-05-12 13:23     ` wsa
2015-05-05 16:32   ` [PATCH 07/27] iio: " Geert Uytterhoeven
2015-05-07 10:37     ` Jonathan Cameron
2015-05-05 16:32   ` [PATCH 08/27] input: " Geert Uytterhoeven
2015-05-05 16:32   ` [PATCH 09/27] leds: " Geert Uytterhoeven
2015-05-06  7:58     ` Jacek Anaszewski
2015-05-06  8:31       ` Geert Uytterhoeven
2015-05-07 12:14     ` Jacek Anaszewski
2015-05-05 16:32   ` [PATCH 10/27] [media] wl128x: " Geert Uytterhoeven
2015-05-05 16:32   ` [PATCH 11/27] mfd: " Geert Uytterhoeven
2015-05-07  7:37     ` Lee Jones
2015-05-05 16:32   ` [PATCH 12/27] misc: ti-st: " Geert Uytterhoeven
2015-05-05 16:32   ` [PATCH 13/27] mtd: " Geert Uytterhoeven
2015-05-05 16:32     ` Geert Uytterhoeven
2015-05-20 22:51     ` Brian Norris
2015-05-20 22:51       ` Brian Norris
2015-05-05 16:32   ` [PATCH 14/27] net: phy: " Geert Uytterhoeven
2015-05-05 16:32   ` [PATCH 15/27] power: " Geert Uytterhoeven
2015-05-05 16:32   ` [PATCH 16/27] regulator: " Geert Uytterhoeven
2015-05-06 15:20     ` Mark Brown
     [not found]   ` <1430843563-18615-1-git-send-email-geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org>
2015-05-05 16:32     ` [PATCH 17/27] spi: " Geert Uytterhoeven
2015-05-05 16:32       ` Geert Uytterhoeven
2015-05-06 15:21       ` Mark Brown
2015-05-05 16:32   ` [PATCH 18/27] staging: android: " Geert Uytterhoeven
2015-05-05 16:32     ` Geert Uytterhoeven
2015-05-05 16:32   ` [PATCH 19/27] staging: fbtft: " Geert Uytterhoeven
2015-05-05 16:32     ` Geert Uytterhoeven
2015-05-05 16:32   ` [PATCH 20/27] Staging: iio: " Geert Uytterhoeven
2015-05-05 16:32     ` Geert Uytterhoeven
2015-05-07 10:38     ` Jonathan Cameron
2015-05-05 16:32   ` [PATCH 21/27] serial: " Geert Uytterhoeven
2015-05-05 16:32   ` [PATCH 22/27] usb: phy: " Geert Uytterhoeven
2015-05-05 16:32   ` [PATCH 23/27] backlight: " Geert Uytterhoeven
2015-05-05 16:32     ` Geert Uytterhoeven
2015-05-07  7:37     ` Lee Jones
2015-05-07  7:37       ` Lee Jones
2015-05-05 16:32   ` [PATCH 24/27] fbdev: " Geert Uytterhoeven
2015-05-05 16:32     ` Geert Uytterhoeven
2015-05-05 16:32   ` [PATCH 25/27] w1: " Geert Uytterhoeven
2015-05-05 16:32   ` [PATCH 26/27] watchdog: " Geert Uytterhoeven
2015-05-05 19:31     ` Guenter Roeck
2015-05-05 16:32   ` [PATCH 27/27] net: rfkill: " Geert Uytterhoeven
2015-06-05 11:20   ` [PATCH 01/27] drm/bridge: ptn3460: #include <linux/gpio/consumer.h>, depend on GPIOLIB Thierry Reding
2015-06-05 11:42     ` Geert Uytterhoeven
2015-06-05 11:42       ` Geert Uytterhoeven
2015-05-12 10:20 ` [PATCH 00/27] gpio: Allow compile test of GPIO consumers if !GPIOLIB Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1430843563-18615-1-git-send-email-geert@linux-m68k.org \
    --to=geert@linux-m68k.org \
    --cc=arnd@arndb.de \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gnurou@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [PATCH 01/27] drm/bridge: ptn3460: #include <linux/gpio/consumer.h>, depend on GPIOLIB' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.