From: Geert Uytterhoeven <geert@linux-m68k.org> To: Linus Walleij <linus.walleij@linaro.org>, Alexandre Courbot <gnurou@gmail.com>, Arnd Bergmann <arnd@arndb.de> Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven <geert@linux-m68k.org>, MyungJoo Ham <myungjoo.ham@samsung.com>, Chanwoo Choi <cw00.choi@samsung.com> Subject: [PATCH 04/27] extcon: Allow compile test of GPIO consumers if !GPIOLIB Date: Tue, 5 May 2015 18:32:20 +0200 [thread overview] Message-ID: <1430843563-18615-4-git-send-email-geert@linux-m68k.org> (raw) In-Reply-To: <1430843563-18615-1-git-send-email-geert@linux-m68k.org> The GPIO subsystem provides dummy GPIO consumer functions if GPIOLIB is not enabled. Hence drivers that depend on GPIOLIB, but use GPIO consumer functionality only, can still be compiled if GPIOLIB is not enabled. Relax the dependency on GPIOLIB if COMPILE_TEST is enabled, where appropriate. If GPIOLIB=n and asm-generic/gpio.h is not used: drivers/extcon/extcon-usb-gpio.c: In function ‘usb_extcon_detect_cable’: drivers/extcon/extcon-usb-gpio.c:63: error: implicit declaration of function ‘gpiod_get_value_cansleep’ drivers/extcon/extcon-usb-gpio.c: In function ‘usb_extcon_probe’: drivers/extcon/extcon-usb-gpio.c:116: error: implicit declaration of function ‘devm_gpiod_get’ drivers/extcon/extcon-usb-gpio.c:116: warning: assignment makes pointer from integer without a cast drivers/extcon/extcon-usb-gpio.c:122: error: implicit declaration of function ‘gpiod_set_debounce’ drivers/extcon/extcon-usb-gpio.c:129: error: implicit declaration of function ‘gpiod_to_irq’ Add the missing #include <linux/gpio/consumer.h> to fix this. Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> Cc: MyungJoo Ham <myungjoo.ham@samsung.com> Cc: Chanwoo Choi <cw00.choi@samsung.com> --- drivers/extcon/Kconfig | 4 ++-- drivers/extcon/extcon-usb-gpio.c | 1 + 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/extcon/Kconfig b/drivers/extcon/Kconfig index fdc0bf0543ce43ec..5d8d7244349870ca 100644 --- a/drivers/extcon/Kconfig +++ b/drivers/extcon/Kconfig @@ -30,7 +30,7 @@ config EXTCON_ARIZONA config EXTCON_GPIO tristate "GPIO extcon support" - depends on GPIOLIB + depends on GPIOLIB || COMPILE_TEST help Say Y here to enable GPIO based extcon support. Note that GPIO extcon supports single state per extcon instance. @@ -105,7 +105,7 @@ config EXTCON_SM5502 config EXTCON_USB_GPIO tristate "USB GPIO extcon support" - depends on GPIOLIB + depends on GPIOLIB || COMPILE_TEST help Say Y here to enable GPIO based USB cable detection extcon support. Used typically if GPIO is used for USB ID pin detection. diff --git a/drivers/extcon/extcon-usb-gpio.c b/drivers/extcon/extcon-usb-gpio.c index de67fce189840eee..6c6fc33029826132 100644 --- a/drivers/extcon/extcon-usb-gpio.c +++ b/drivers/extcon/extcon-usb-gpio.c @@ -15,6 +15,7 @@ */ #include <linux/extcon.h> +#include <linux/gpio/consumer.h> #include <linux/init.h> #include <linux/interrupt.h> #include <linux/irq.h> -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Geert Uytterhoeven <geert@linux-m68k.org> To: Linus Walleij <linus.walleij@linaro.org>, Alexandre Courbot <gnurou@gmail.com>, Arnd Bergmann <arnd@arndb.de> Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven <geert@linux-m68k.org>, MyungJoo Ham <myungjoo.ham@samsung.com>, Chanwoo Choi <cw00.choi@samsung.com> Subject: [PATCH 04/27] extcon: Allow compile test of GPIO consumers if !GPIOLIB Date: Tue, 5 May 2015 18:32:20 +0200 [thread overview] Message-ID: <1430843563-18615-4-git-send-email-geert@linux-m68k.org> (raw) In-Reply-To: <1430843563-18615-1-git-send-email-geert@linux-m68k.org> The GPIO subsystem provides dummy GPIO consumer functions if GPIOLIB is not enabled. Hence drivers that depend on GPIOLIB, but use GPIO consumer functionality only, can still be compiled if GPIOLIB is not enabled. Relax the dependency on GPIOLIB if COMPILE_TEST is enabled, where appropriate. If GPIOLIB=n and asm-generic/gpio.h is not used: drivers/extcon/extcon-usb-gpio.c: In function ‘usb_extcon_detect_cable’: drivers/extcon/extcon-usb-gpio.c:63: error: implicit declaration of function ‘gpiod_get_value_cansleep’ drivers/extcon/extcon-usb-gpio.c: In function ‘usb_extcon_probe’: drivers/extcon/extcon-usb-gpio.c:116: error: implicit declaration of function ‘devm_gpiod_get’ drivers/extcon/extcon-usb-gpio.c:116: warning: assignment makes pointer from integer without a cast drivers/extcon/extcon-usb-gpio.c:122: error: implicit declaration of function ‘gpiod_set_debounce’ drivers/extcon/extcon-usb-gpio.c:129: error: implicit declaration of function ‘gpiod_to_irq’ Add the missing #include <linux/gpio/consumer.h> to fix this. Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> Cc: MyungJoo Ham <myungjoo.ham@samsung.com> Cc: Chanwoo Choi <cw00.choi@samsung.com> --- drivers/extcon/Kconfig | 4 ++-- drivers/extcon/extcon-usb-gpio.c | 1 + 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/extcon/Kconfig b/drivers/extcon/Kconfig index fdc0bf0543ce43ec..5d8d7244349870ca 100644 --- a/drivers/extcon/Kconfig +++ b/drivers/extcon/Kconfig @@ -30,7 +30,7 @@ config EXTCON_ARIZONA config EXTCON_GPIO tristate "GPIO extcon support" - depends on GPIOLIB + depends on GPIOLIB || COMPILE_TEST help Say Y here to enable GPIO based extcon support. Note that GPIO extcon supports single state per extcon instance. @@ -105,7 +105,7 @@ config EXTCON_SM5502 config EXTCON_USB_GPIO tristate "USB GPIO extcon support" - depends on GPIOLIB + depends on GPIOLIB || COMPILE_TEST help Say Y here to enable GPIO based USB cable detection extcon support. Used typically if GPIO is used for USB ID pin detection. diff --git a/drivers/extcon/extcon-usb-gpio.c b/drivers/extcon/extcon-usb-gpio.c index de67fce189840eee..6c6fc33029826132 100644 --- a/drivers/extcon/extcon-usb-gpio.c +++ b/drivers/extcon/extcon-usb-gpio.c @@ -15,6 +15,7 @@ */ #include <linux/extcon.h> +#include <linux/gpio/consumer.h> #include <linux/init.h> #include <linux/interrupt.h> #include <linux/irq.h> -- 1.9.1
next prev parent reply other threads:[~2015-05-05 16:32 UTC|newest] Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-05-05 14:33 [PATCH 00/27] gpio: Allow compile test of GPIO consumers if !GPIOLIB Geert Uytterhoeven 2015-05-05 16:32 ` [PATCH 01/27] drm/bridge: ptn3460: #include <linux/gpio/consumer.h>, depend on GPIOLIB Geert Uytterhoeven 2015-05-05 16:32 ` Geert Uytterhoeven 2015-05-05 16:32 ` [PATCH 02/27] drm/bridge: ps8622: " Geert Uytterhoeven 2015-06-05 11:21 ` Thierry Reding 2015-05-05 16:32 ` [PATCH 03/27] tpm: Allow compile test of GPIO consumers if !GPIOLIB Geert Uytterhoeven 2015-05-05 20:57 ` Peter Hüwe 2015-05-05 16:32 ` Geert Uytterhoeven [this message] 2015-05-05 16:32 ` [PATCH 04/27] extcon: " Geert Uytterhoeven 2015-05-06 5:38 ` Chanwoo Choi 2015-05-05 16:32 ` [PATCH 05/27] hwmon: " Geert Uytterhoeven 2015-05-05 16:32 ` Geert Uytterhoeven 2015-05-05 19:31 ` Guenter Roeck 2015-05-05 16:32 ` [PATCH 06/27] i2c: " Geert Uytterhoeven 2015-05-12 13:23 ` wsa 2015-05-05 16:32 ` [PATCH 07/27] iio: " Geert Uytterhoeven 2015-05-07 10:37 ` Jonathan Cameron 2015-05-05 16:32 ` [PATCH 08/27] input: " Geert Uytterhoeven 2015-05-05 16:32 ` [PATCH 09/27] leds: " Geert Uytterhoeven 2015-05-06 7:58 ` Jacek Anaszewski 2015-05-06 8:31 ` Geert Uytterhoeven 2015-05-07 12:14 ` Jacek Anaszewski 2015-05-05 16:32 ` [PATCH 10/27] [media] wl128x: " Geert Uytterhoeven 2015-05-05 16:32 ` [PATCH 11/27] mfd: " Geert Uytterhoeven 2015-05-07 7:37 ` Lee Jones 2015-05-05 16:32 ` [PATCH 12/27] misc: ti-st: " Geert Uytterhoeven 2015-05-05 16:32 ` [PATCH 13/27] mtd: " Geert Uytterhoeven 2015-05-05 16:32 ` Geert Uytterhoeven 2015-05-20 22:51 ` Brian Norris 2015-05-20 22:51 ` Brian Norris 2015-05-05 16:32 ` [PATCH 14/27] net: phy: " Geert Uytterhoeven 2015-05-05 16:32 ` [PATCH 15/27] power: " Geert Uytterhoeven 2015-05-05 16:32 ` [PATCH 16/27] regulator: " Geert Uytterhoeven 2015-05-06 15:20 ` Mark Brown [not found] ` <1430843563-18615-1-git-send-email-geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org> 2015-05-05 16:32 ` [PATCH 17/27] spi: " Geert Uytterhoeven 2015-05-05 16:32 ` Geert Uytterhoeven 2015-05-06 15:21 ` Mark Brown 2015-05-05 16:32 ` [PATCH 18/27] staging: android: " Geert Uytterhoeven 2015-05-05 16:32 ` Geert Uytterhoeven 2015-05-05 16:32 ` [PATCH 19/27] staging: fbtft: " Geert Uytterhoeven 2015-05-05 16:32 ` Geert Uytterhoeven 2015-05-05 16:32 ` [PATCH 20/27] Staging: iio: " Geert Uytterhoeven 2015-05-05 16:32 ` Geert Uytterhoeven 2015-05-07 10:38 ` Jonathan Cameron 2015-05-05 16:32 ` [PATCH 21/27] serial: " Geert Uytterhoeven 2015-05-05 16:32 ` [PATCH 22/27] usb: phy: " Geert Uytterhoeven 2015-05-05 16:32 ` [PATCH 23/27] backlight: " Geert Uytterhoeven 2015-05-05 16:32 ` Geert Uytterhoeven 2015-05-07 7:37 ` Lee Jones 2015-05-07 7:37 ` Lee Jones 2015-05-05 16:32 ` [PATCH 24/27] fbdev: " Geert Uytterhoeven 2015-05-05 16:32 ` Geert Uytterhoeven 2015-05-05 16:32 ` [PATCH 25/27] w1: " Geert Uytterhoeven 2015-05-05 16:32 ` [PATCH 26/27] watchdog: " Geert Uytterhoeven 2015-05-05 19:31 ` Guenter Roeck 2015-05-05 16:32 ` [PATCH 27/27] net: rfkill: " Geert Uytterhoeven 2015-06-05 11:20 ` [PATCH 01/27] drm/bridge: ptn3460: #include <linux/gpio/consumer.h>, depend on GPIOLIB Thierry Reding 2015-06-05 11:42 ` Geert Uytterhoeven 2015-06-05 11:42 ` Geert Uytterhoeven 2015-05-12 10:20 ` [PATCH 00/27] gpio: Allow compile test of GPIO consumers if !GPIOLIB Linus Walleij
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1430843563-18615-4-git-send-email-geert@linux-m68k.org \ --to=geert@linux-m68k.org \ --cc=arnd@arndb.de \ --cc=cw00.choi@samsung.com \ --cc=gnurou@gmail.com \ --cc=linus.walleij@linaro.org \ --cc=linux-gpio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=myungjoo.ham@samsung.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.