All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Hon Ching(Vicky) Lo" <honclo@linux.vnet.ibm.com>
To: tpmdd-devel@lists.sourceforge.net
Cc: Peter Huewe <PeterHuewe@gmx.de>,
	Ashley Lai <ashley@ashleylai.com>,
	Mimi Zohar <zohar@linux.vnet.ibm.com>,
	Vicky Lo <honclo2014@gmail.com>,
	linux-kernel@vger.kernel.org,
	"Hon Ching(Vicky) Lo" <honclo@linux.vnet.ibm.com>,
	Joy Latten <jmlatten@linux.vnet.ibm.com>
Subject: [PATCH 1/3] vTPM: fixed the limit checking
Date: Tue,  5 May 2015 20:51:24 -0400	[thread overview]
Message-ID: <1430873486-25868-2-git-send-email-honclo@linux.vnet.ibm.com> (raw)
In-Reply-To: <1430873486-25868-1-git-send-email-honclo@linux.vnet.ibm.com>

Do not skip the last entry of the event log.

Signed-off-by: Hon Ching(Vicky) Lo <honclo@linux.vnet.ibm.com>
Signed-off-by: Joy Latten <jmlatten@linux.vnet.ibm.com>

Changelog:
- remove redundant code
---
 drivers/char/tpm/tpm_eventlog.c |    5 +----
 1 files changed, 1 insertions(+), 4 deletions(-)

diff --git a/drivers/char/tpm/tpm_eventlog.c b/drivers/char/tpm/tpm_eventlog.c
index 3a56a13..e77d8c1 100644
--- a/drivers/char/tpm/tpm_eventlog.c
+++ b/drivers/char/tpm/tpm_eventlog.c
@@ -116,11 +116,8 @@ static void *tpm_bios_measurements_next(struct seq_file *m, void *v,
 
 	event = v;
 
-	if (event->event_type == 0 && event->event_size == 0)
-		return NULL;
-
 	if ((event->event_type == 0 && event->event_size == 0) ||
-	    ((v + sizeof(struct tcpa_event) + event->event_size) >= limit))
+	    ((v + sizeof(struct tcpa_event) + event->event_size) > limit))
 		return NULL;
 
 	(*pos)++;
-- 
1.7.1


  reply	other threads:[~2015-05-06  0:53 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-06  0:51 [PATCH 0/3] additional little endian support Hon Ching(Vicky) Lo
2015-05-06  0:51 ` Hon Ching(Vicky) Lo [this message]
2015-05-11 13:02   ` [tpmdd-devel] [PATCH 1/3] vTPM: fixed the limit checking Stefan Berger
2015-05-12 21:19     ` Joy M. Latten
2015-05-06  0:51 ` [PATCH 2/3] TPM: remove unnecessary little endian conversion Hon Ching(Vicky) Lo
2015-05-06  0:51 ` [PATCH 3/3] vTPM: support little endian guests Hon Ching(Vicky) Lo
2015-05-08 22:31   ` Ashley Lai
2015-05-08 23:10     ` Hon Ching (Vicky) Lo
2015-05-11 22:07     ` Joy M. Latten
2015-05-19 21:08   ` Ashley Lai
2015-05-19 21:18     ` Ashley Lai
2015-05-20 21:23     ` Hon Ching (Vicky) Lo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1430873486-25868-2-git-send-email-honclo@linux.vnet.ibm.com \
    --to=honclo@linux.vnet.ibm.com \
    --cc=PeterHuewe@gmx.de \
    --cc=ashley@ashleylai.com \
    --cc=honclo2014@gmail.com \
    --cc=jmlatten@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tpmdd-devel@lists.sourceforge.net \
    --cc=zohar@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.