From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [OSSTEST Nested PATCH v9 3/9] Refactor installation
 of overlays for guest used
Date: Wed, 6 May 2015 11:49:33 +0100
Message-ID: <1430909373.2660.215.camel@citrix.com>
References: <1430548098-5233-1-git-send-email-longtaox.pang@intel.com>
	<1430548098-5233-4-git-send-email-longtaox.pang@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1430548098-5233-4-git-send-email-longtaox.pang@intel.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: "longtao.pang" <longtaox.pang@intel.com>
Cc: wei.liu2@citrix.com, robert.hu@intel.com, Ian.Jackson@eu.citrix.com, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On Sat, 2015-05-02 at 14:28 +0800, longtao.pang wrote:
> From: "longtao.pang" <longtaox.pang@intel.com>
> 
> Based on Ian Campbell's v5_patch [04,05,06], I create this patch
> to refactor installation of overlays for guest used.
> 
> Link of Ian Campbell's patch:
> http://lists.xenproject.org/archives/html/xen-devel/2015-04/msg01452.html
> http://lists.xenproject.org/archives/html/xen-devel/2015-04/msg01447.html

This information is useful in the context of posting, but it should be
after the main body of the commit log and a --- marker so it isn't
included when committing.

The actual body of the commit message should offer some explanation of
how/why it is safe to apply the overlay to guests as well as hosts as
well as why you want it for guests.

Something like:

        Apply overlay to guests as well as hosts by moving to
        preseed_base.
        
        We do this because we want to be able to:
        
              * Use /etc/init.d/osstest-confirm-booted for guests as
                well as hosts (in particular when testing nestedhvm we
                sometimes want to treat a guest as a host)
              * Use grub's 20_linux_xen which is harmless unless Xen is
                installed in the guest which is the case only for
                nestedhvm testing when we want these changes.
        
        The other things in the overlay are some initscripts (xenbridge
        and xenlightdaemons) which are not enabled for guests and hence
        are therefore harmless.
        
        Signed-off-by: longtao.pang <longtaox.pang@intel.com>
        ---
        Base on Ian Campbell's v5_patch [04,05,06], I create this
        patch... etc

> @@ -624,6 +624,7 @@ sub preseed_base ($$$$;@) {
>  
>      preseed_ssh($ho, $sfx);
>      preseed_hook_overlay($ho, $sfx, $c{OverlayLocal}, 'overlay-local.tar');
> +    preseed_hook_overlay($ho, $sfx, 'overlay', 'overlay.tar');

I think you should also remove the existing one from preseed_create,
else it will happen twice for L0 host install.

Ian.