From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [OSSTEST Nested PATCH v9 4/9] Edit some APIs in
 TestSupport.pm for nested test
Date: Wed, 6 May 2015 11:55:15 +0100
Message-ID: <1430909715.2660.219.camel@citrix.com>
References: <1430548098-5233-1-git-send-email-longtaox.pang@intel.com>
	<1430548098-5233-5-git-send-email-longtaox.pang@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1430548098-5233-5-git-send-email-longtaox.pang@intel.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: "longtao.pang" <longtaox.pang@intel.com>
Cc: wei.liu2@citrix.com, robert.hu@intel.com, Ian.Jackson@eu.citrix.com, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On Sat, 2015-05-02 at 14:28 +0800, longtao.pang wrote:
> From: "longtao.pang" <longtaox.pang@intel.com>
> 
> 1. If vif model is defined for guest, use it in guest's configuration
> 2. In L2 installation context, its host (L1) shall not have a static IP
> but stored in runvar in L1 installation before; use this stored runvar
> IP.
> 
> Signed-off-by: longtao.pang <longtaox.pang@intel.com>

The code looks good, thanks. I have some minor formatting/wording nits.

> @@ -1513,14 +1517,15 @@ sub prepareguest ($$$$$$) {
>      store_runvar("${gn}_hostname", $hostname);
>      store_runvar("${gn}_tcpcheckport", $tcpcheckport);
>      store_runvar("${gn}_boot_timeout", $boot_timeout);

Blank line here please.

> +    my $gho= selectguest($gn, $ho);
> +    store_runvar("${gn}_domname", $gho->{Name});

A blank line here please.

> +    #if we have defined guest specific disksize, override it

Space after "#" please and ideally "If" not "if".

I would say "use it" rather than "override it".

> +    $mb = guest_var($gho,'disksize',$mb);
>  

And no blank line here. (i.e. assignment of $mb nestles against the
following if and not the preceding store_runvar)

With that stuff fixed: Acked-by: Ian Campbell <ian.campbell@citrix.com>