From: Ian Campbell <ian.campbell@citrix.com>
To: "longtao.pang" <longtaox.pang@intel.com>
Cc: wei.liu2@citrix.com, robert.hu@intel.com,
Ian.Jackson@eu.citrix.com, xen-devel@lists.xen.org
Subject: Re: [OSSTEST Nested PATCH v9 9/9] Add test job for nest test case
Date: Wed, 6 May 2015 12:07:49 +0100 [thread overview]
Message-ID: <1430910469.2660.230.camel@citrix.com> (raw)
In-Reply-To: <1430548098-5233-10-git-send-email-longtaox.pang@intel.com>
On Sat, 2015-05-02 at 14:28 +0800, longtao.pang wrote:
> diff --git a/make-flight b/make-flight
> index cc8ecdb..b5c7c27 100755
> --- a/make-flight
> +++ b/make-flight
> @@ -204,6 +204,37 @@ do_hvm_win7_x64_tests () {
> all_hostflags=$most_hostflags,hvm
> }
>
> +do_hvm_debian_nested_tests () {
> + if [ $xenarch != amd64 -o $dom0arch != amd64 \
> + -o "x$qemuu_suffix" != "x-qemuu" ]; then
> + return
> + fi
> +
> + case $xenbranch in
> + xen-3.*-testing) return;;
> + xen-4.0-testing) return;;
> + xen-4.1-testing) return;;
> + xen-4.2-testing) return;;
> + xen-4.3-testing) return;;
> + esac
> + # Define bios type, in 'ts-debian-hvm-install' script will use it,
> + # or will die if "$r{bios}" undefined.
> + bios=$1
Please can you just put
bios=$1
as the first line in the function, followed by a blank line, followed by
the $xenarch/$domarch/$qemuu_suffix test. No need for the comment.
> +
> + job_create_test test-$xenarch$kern-$dom0arch$qemuu_suffix-nested \
> + test-nested xl $xenarch $dom0arch $qemuu_runvar \
> + nestedl1_image=debian-7.2.0-amd64-CD-1.iso \
> + nestedl1_vifmodel='e1000' \
> + nestedl1_disksize='15000' \
> + nestedl1_memsize='3072' \
> + nestedl1_enable_nestedhvm='true' \
> + nestedl1_guest_storage_size='20000' \
> + nestedl2_image=debian-7.2.0-amd64-CD-1.iso \
> + nestedl2_disksize='15000' \
> + bios=$bios
> + all_hostflags=$most_hostflags,hvm
Looks good, thanks.
With the bios= moved:
Acked-by: Ian Campbell <ian.campbell@citrix.com>
Ian.
prev parent reply other threads:[~2015-05-06 11:07 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-02 6:28 [OSSTEST Nested PATCH v9 0/9] Introduction of netsted HVM test job longtao.pang
2015-05-02 6:28 ` [OSSTEST Nested PATCH v9 1/9] parsing grub which has 'submenu' primitive longtao.pang
2015-05-06 11:36 ` Ian Campbell
2015-05-02 6:28 ` [OSSTEST Nested PATCH v9 2/9] Changes to support '/boot' leading paths of kernel, xen, in grub longtao.pang
2015-05-06 10:41 ` Ian Campbell
2015-05-02 6:28 ` [OSSTEST Nested PATCH v9 3/9] Refactor installation of overlays for guest used longtao.pang
2015-05-06 10:49 ` Ian Campbell
2015-05-02 6:28 ` [OSSTEST Nested PATCH v9 4/9] Edit some APIs in TestSupport.pm for nested test longtao.pang
2015-05-06 10:55 ` Ian Campbell
2015-05-02 6:28 ` [OSSTEST Nested PATCH v9 5/9] Move the codes about memory size setting into prep() longtao.pang
2015-05-06 10:57 ` Ian Campbell
2015-05-02 6:28 ` [OSSTEST Nested PATCH v9 6/9] Changes on test step of Debian hvm guest install longtao.pang
2015-05-06 11:03 ` Ian Campbell
2015-05-02 6:28 ` [OSSTEST Nested PATCH v9 7/9] Add new script to customize nested test configuration longtao.pang
2015-05-06 11:36 ` Ian Campbell
2015-05-07 7:42 ` Pang, LongtaoX
2015-05-07 9:16 ` Ian Campbell
2015-05-02 6:28 ` [OSSTEST Nested PATCH v9 8/9] Compose the main recipe of nested test job longtao.pang
2015-05-06 11:04 ` Ian Campbell
2015-05-02 6:28 ` [OSSTEST Nested PATCH v9 9/9] Add test job for nest test case longtao.pang
2015-05-06 11:07 ` Ian Campbell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1430910469.2660.230.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=longtaox.pang@intel.com \
--cc=robert.hu@intel.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.