From: Geoff Levand <geoff@infradead.org>
To: Pratyush Anand <panand@redhat.com>
Cc: kexec@lists.infradead.org
Subject: Re: [PATCH] arm64: Kexec: Add support for binary image
Date: Wed, 06 May 2015 10:34:41 -0700 [thread overview]
Message-ID: <1430933681.12082.23.camel@infradead.org> (raw)
In-Reply-To: <770bae1ed7d53e74874f99343070b4c5a69cb9a2.1429704995.git.panand@redhat.com>
Hi,
On Wed, 2015-04-22 at 17:56 +0530, Pratyush Anand wrote:
> @@ -30,6 +32,7 @@ static const char arm64_opts_usage[] __attribute__ ((unused)) =
> " --dtb=FILE Use FILE as the device tree blob.\n"
> " --initrd=FILE Use FILE as the kernel initial ramdisk.\n"
> " --lite Fast reboot, no memory integrity checks.\n"
> +" --page-offset Kernel page-offset for binary image load.\n"
Sorry I didn't see this before, but page-offset is for Image load, so
should go in the image_arm64_usage().
I think it is OK to keep page_offset in struct arm64_opts, then just
ignore it for the other file formats.
> " --port=ADDRESS Purgatory output to port ADDRESS.\n"
> " --ramdisk=FILE Use FILE as the kernel initial ramdisk.\n"
> " --reuse-cmdline Use command line arg of primary kernel.\n";
> --- a/kexec/arch/arm64/kexec-image-arm64.c
> +++ b/kexec/arch/arm64/kexec-image-arm64.c
> +static unsigned long long get_kernel_page_offset(void)
> +{
> + unsigned long long text_sym_addr = get_kernel_text_sym();
> + unsigned long long text_page_offset =
> + text_sym_addr & 0xFFFFFFFFFFE00000;
> +
> + if(arm64_opts.page_offset) {
> + if (text_page_offset != arm64_opts.page_offset)
> + dbgprintf("User page offset did not match with text page offset\n");
I'd like to see the values printed.
> + return arm64_opts.page_offset;
> + } else if(text_page_offset) {
> + dbgprintf("text page offset is %llx\n", text_page_offset);
> + return text_page_offset;
> + } else {
> + return ARM64_DEFAULT_PAGE_OFFSET;
> + }
> }
-Geoff
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2015-05-06 17:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-22 12:26 [PATCH] arm64: Kexec: Add support for binary image Pratyush Anand
2015-04-22 12:26 ` [PATCH] arm64: kdump: " Pratyush Anand
2015-04-22 12:26 ` [PATCH] arm64: wait for transmit completion before next character transmission Pratyush Anand
2015-05-06 17:34 ` Geoff Levand [this message]
2015-05-14 5:12 ` [PATCH] arm64: Kexec: Add support for binary image Pratyush Anand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1430933681.12082.23.camel@infradead.org \
--to=geoff@infradead.org \
--cc=kexec@lists.infradead.org \
--cc=panand@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.